[GitHub] [hadoop-ozone] bshashikant commented on a change in pull request #833: HDDS-3314. scmcli container info command failing intermittently

[GitBox <gi...@apache.org>]

bshashikant commented on a change in pull request #833: HDDS-3314. scmcli container info command failing intermittently
URL: https://github.com/apache/hadoop-ozone/pull/833#discussion_r410099334
 
 

 ##########
 File path: hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/ContainerOperationClient.java
 ##########
 @@ -382,7 +382,7 @@ public ContainerDataProto readContainer(long containerID,
       Pipeline pipeline) throws IOException {
     XceiverClientSpi client = null;
     try {
-      client = xceiverClientManager.acquireClient(pipeline);
+      client = xceiverClientManager.acquireClientForReadData(pipeline);
 
 Review comment:
   @bharat, if we use acquireClientForReadData, it will use XceiverClientGrpc to read the info rather than Ratis(which reads from the leader). XceiverClientGrpc automatically fails over from datanode to another if it sees a failure.
   
   InfoSubCommand has recently been changed to not use readContainer call to read data from datanode. But , in Ozone, we only use XceiverClientGrpc to read from datanode , it make sense here to use the same while reading the containerData as well (acquireClient -> acquireClientForReadData). This function is used by ChunkKeyHandler.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org