You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/10/27 23:59:00 UTC
Re: Review Request 63060: Added utility functions and structures for
CSI version and capabilities.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63060/
-----------------------------------------------------------
(Updated Oct. 27, 2017, 11:58 p.m.)
Review request for mesos, Benjamin Mahler and Jie Yu.
Changes
-------
Removed the default clauses for switch statements on proto3 enums.
Summary (updated)
-----------------
Added utility functions and structures for CSI version and capabilities.
Repository: mesos
Description (updated)
-------
This patch adds some helper structures and functions for CSI protobuf.
The comparison and output operators for `csi::Version` are declared in
the `::csi` namespace so they can find it through ADL. Also, it exposes
`::csi` in `mesos::csi` in `spec.hpp` instead of `client.hpp`.
Diffs (updated)
-----
src/Makefile.am b60a54a031260de6f1fb43584ae5083df2dc7e31
src/csi/client.hpp df674e17260519f983367f7c01f1057a75076238
src/csi/spec.hpp 60e40e05d81c9bf649459e29479838dd80daa3aa
src/csi/utils.hpp PRE-CREATION
src/csi/utils.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/63060/diff/3/
Changes: https://reviews.apache.org/r/63060/diff/2-3/
Testing
-------
make
Thanks,
Chun-Hung Hsiao
Re: Review Request 63060: Added utility functions and structures for
CSI version and capabilities.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63060/
-----------------------------------------------------------
(Updated Nov. 28, 2017, 12:56 a.m.)
Review request for mesos, Benjamin Mahler and Jie Yu.
Changes
-------
Removed the `csi::` prefix. Since the helper functions are moved into the `::csi` namespace, the prefix is no longer needed.
Repository: mesos
Description
-------
This patch adds some helper structures and functions for CSI protobuf.
The comparison and output operators for `csi::Version` are declared in
the `::csi` namespace so they can find it through ADL. Also, it exposes
`::csi` in `mesos::csi` in `spec.hpp` instead of `client.hpp`.
Diffs (updated)
-----
src/Makefile.am 9641ad4cf2a1f7fe56a4dcccb6eeff7130872fa8
src/csi/client.hpp a5571f40eba60a07154a7ef3ebe36c925629ac63
src/csi/spec.hpp 60e40e05d81c9bf649459e29479838dd80daa3aa
src/csi/utils.hpp PRE-CREATION
src/csi/utils.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/63060/diff/6/
Changes: https://reviews.apache.org/r/63060/diff/5-6/
Testing
-------
make
Thanks,
Chun-Hung Hsiao
Re: Review Request 63060: Added utility functions and structures for
CSI version and capabilities.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63060/
-----------------------------------------------------------
(Updated Nov. 22, 2017, 5:19 a.m.)
Review request for mesos, Benjamin Mahler and Jie Yu.
Changes
-------
Fixed indentation.
Repository: mesos
Description
-------
This patch adds some helper structures and functions for CSI protobuf.
The comparison and output operators for `csi::Version` are declared in
the `::csi` namespace so they can find it through ADL. Also, it exposes
`::csi` in `mesos::csi` in `spec.hpp` instead of `client.hpp`.
Diffs (updated)
-----
src/Makefile.am 9641ad4cf2a1f7fe56a4dcccb6eeff7130872fa8
src/csi/client.hpp a5571f40eba60a07154a7ef3ebe36c925629ac63
src/csi/spec.hpp 60e40e05d81c9bf649459e29479838dd80daa3aa
src/csi/utils.hpp PRE-CREATION
src/csi/utils.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/63060/diff/5/
Changes: https://reviews.apache.org/r/63060/diff/4-5/
Testing
-------
make
Thanks,
Chun-Hung Hsiao
Re: Review Request 63060: Added utility functions and structures for
CSI version and capabilities.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63060/
-----------------------------------------------------------
(Updated Nov. 21, 2017, 7:55 p.m.)
Review request for mesos, Benjamin Mahler and Jie Yu.
Changes
-------
Updated based on the new CSI spec.
Repository: mesos
Description
-------
This patch adds some helper structures and functions for CSI protobuf.
The comparison and output operators for `csi::Version` are declared in
the `::csi` namespace so they can find it through ADL. Also, it exposes
`::csi` in `mesos::csi` in `spec.hpp` instead of `client.hpp`.
Diffs (updated)
-----
src/Makefile.am 9641ad4cf2a1f7fe56a4dcccb6eeff7130872fa8
src/csi/client.hpp a5571f40eba60a07154a7ef3ebe36c925629ac63
src/csi/spec.hpp 60e40e05d81c9bf649459e29479838dd80daa3aa
src/csi/utils.hpp PRE-CREATION
src/csi/utils.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/63060/diff/4/
Changes: https://reviews.apache.org/r/63060/diff/3-4/
Testing
-------
make
Thanks,
Chun-Hung Hsiao