You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "David Mollitor (Jira)" <ji...@apache.org> on 2020/04/21 19:03:00 UTC
[jira] [Updated] (HIVE-23266) Remove QueryWrapper from ObjectStore
[ https://issues.apache.org/jira/browse/HIVE-23266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Mollitor updated HIVE-23266:
----------------------------------
Description:
There is currently a utility called {{QueryWrapper}} that makes a normal {{Query}} auto-closable. However, {{Query}} is now in fact already auto-closing, so there is no need for this class. In trying to remove it, I realized that this wrapper was being passed around in pretty convoluted ways and also it was sometimes being created in a {{try-with-resources}} block but then never actually used in any way.
Remove the {{QueryWrapper}} from the class and simplify some of the DB interactions.
https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L178
was:
There is currently a utility called {{QueryWrapper}} that makes a normal {{Query}} auto-closable. However, {{Query}} is now in fact already auto-closing, so there is no need for this class. In trying to remove it, I realized that this wrapper was being passed around in pretty convoluted ways and also it was sometimes being created in a {{try-with-resources}} block but then never actually used in anyway.
Remove the {{QueryWrapper}} from the class and simplify some of the DB interactions.
https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L178
> Remove QueryWrapper from ObjectStore
> ------------------------------------
>
> Key: HIVE-23266
> URL: https://issues.apache.org/jira/browse/HIVE-23266
> Project: Hive
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Major
>
> There is currently a utility called {{QueryWrapper}} that makes a normal {{Query}} auto-closable. However, {{Query}} is now in fact already auto-closing, so there is no need for this class. In trying to remove it, I realized that this wrapper was being passed around in pretty convoluted ways and also it was sometimes being created in a {{try-with-resources}} block but then never actually used in any way.
> Remove the {{QueryWrapper}} from the class and simplify some of the DB interactions.
> https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L178
--
This message was sent by Atlassian Jira
(v8.3.4#803005)