You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Jose L Martinez-Avial (Created) (JIRA)" <ji...@apache.org> on 2012/04/20 06:43:38 UTC
[jira] [Created] (WW-3804) tag s:radio does not support dynamic
attributes
tag s:radio does not support dynamic attributes
-----------------------------------------------
Key: WW-3804
URL: https://issues.apache.org/jira/browse/WW-3804
Project: Struts 2
Issue Type: Improvement
Components: Plugin - Tags
Affects Versions: 2.3.3
Reporter: Jose L Martinez-Avial
Priority: Minor
The tag s:radio does not support dynamic attributes. As a result, integration with javascript frameworks like Dojo does not work (it's not possible to setup the attribute dojoType or data-dojo-type)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (WW-3804) tag s:radio does not support dynamic
attributes
Posted by "Lukasz Lenart (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lukasz Lenart reassigned WW-3804:
---------------------------------
Assignee: Lukasz Lenart
> tag s:radio does not support dynamic attributes
> -----------------------------------------------
>
> Key: WW-3804
> URL: https://issues.apache.org/jira/browse/WW-3804
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - Tags
> Affects Versions: 2.3.3
> Reporter: Jose L Martinez-Avial
> Assignee: Lukasz Lenart
> Priority: Minor
> Labels: dynamic, tag
> Fix For: 2.3.4
>
>
> The tag s:radio does not support dynamic attributes. As a result, integration with javascript frameworks like Dojo does not work (it's not possible to setup the attribute dojoType or data-dojo-type)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3804) tag s:radio does not support dynamic
attributes
Posted by "Lukasz Lenart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400474#comment-13400474 ]
Lukasz Lenart commented on WW-3804:
-----------------------------------
Are you sure ? Check the test case
http://svn.apache.org/repos/asf/struts/struts2/trunk/core/src/test/java/org/apache/struts2/views/jsp/ui/RadioTest.java
https://svn.apache.org/repos/asf/struts/struts2/trunk/core/src/test/resources/org/apache/struts2/views/jsp/ui/Radio-7.txt
> tag s:radio does not support dynamic attributes
> -----------------------------------------------
>
> Key: WW-3804
> URL: https://issues.apache.org/jira/browse/WW-3804
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - Tags
> Affects Versions: 2.3.3
> Reporter: Jose L Martinez-Avial
> Assignee: Lukasz Lenart
> Priority: Minor
> Labels: dynamic, tag
> Fix For: 2.3.4
>
>
> The tag s:radio does not support dynamic attributes. As a result, integration with javascript frameworks like Dojo does not work (it's not possible to setup the attribute dojoType or data-dojo-type)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3804) tag s:radio does not support dynamic
attributes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258648#comment-13258648 ]
Hudson commented on WW-3804:
----------------------------
Integrated in Struts2 #461 (See [https://builds.apache.org/job/Struts2/461/])
WW-3804 adds support of dynamic attributes to <s:radio/> tag and extends support for dynamic attributes with expression evaluation (Revision 1328526)
Result = SUCCESS
lukaszlenart :
Files :
* /struts/struts2/trunk/core/src/main/java/org/apache/struts2/util/StrutsUtil.java
* /struts/struts2/trunk/core/src/main/resources/template/simple/dynamic-attributes.ftl
* /struts/struts2/trunk/core/src/main/resources/template/simple/radiomap.ftl
* /struts/struts2/trunk/core/src/test/java/org/apache/struts2/util/StrutsUtilTest.java
* /struts/struts2/trunk/core/src/test/java/org/apache/struts2/views/jsp/ui/RadioTest.java
* /struts/struts2/trunk/core/src/test/resources/org/apache/struts2/views/jsp/ui/Radio-7.txt
> tag s:radio does not support dynamic attributes
> -----------------------------------------------
>
> Key: WW-3804
> URL: https://issues.apache.org/jira/browse/WW-3804
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - Tags
> Affects Versions: 2.3.3
> Reporter: Jose L Martinez-Avial
> Assignee: Lukasz Lenart
> Priority: Minor
> Labels: dynamic, tag
> Fix For: 2.3.4
>
>
> The tag s:radio does not support dynamic attributes. As a result, integration with javascript frameworks like Dojo does not work (it's not possible to setup the attribute dojoType or data-dojo-type)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3804) tag s:radio does not support dynamic
attributes
Posted by "Jon Moores (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400465#comment-13400465 ]
Jon Moores commented on WW-3804:
--------------------------------
After downloading 2.3.4 this doesnt appear to be fixed. Did it make it to the 2.3.4 release ?
> tag s:radio does not support dynamic attributes
> -----------------------------------------------
>
> Key: WW-3804
> URL: https://issues.apache.org/jira/browse/WW-3804
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - Tags
> Affects Versions: 2.3.3
> Reporter: Jose L Martinez-Avial
> Assignee: Lukasz Lenart
> Priority: Minor
> Labels: dynamic, tag
> Fix For: 2.3.4
>
>
> The tag s:radio does not support dynamic attributes. As a result, integration with javascript frameworks like Dojo does not work (it's not possible to setup the attribute dojoType or data-dojo-type)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WW-3804) tag s:radio does not support dynamic
attributes
Posted by "Lukasz Lenart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lukasz Lenart resolved WW-3804.
-------------------------------
Resolution: Fixed
Done, solved! Thanks for reporting!
Added also support for expressions in values of dynamic attributes
https://cwiki.apache.org/confluence/display/WW/Freemarker+Support
> tag s:radio does not support dynamic attributes
> -----------------------------------------------
>
> Key: WW-3804
> URL: https://issues.apache.org/jira/browse/WW-3804
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - Tags
> Affects Versions: 2.3.3
> Reporter: Jose L Martinez-Avial
> Assignee: Lukasz Lenart
> Priority: Minor
> Labels: dynamic, tag
> Fix For: 2.3.4
>
>
> The tag s:radio does not support dynamic attributes. As a result, integration with javascript frameworks like Dojo does not work (it's not possible to setup the attribute dojoType or data-dojo-type)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WW-3804) tag s:radio does not support dynamic
attributes
Posted by "Lukasz Lenart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lukasz Lenart resolved WW-3804.
-------------------------------
Resolution: Fixed
Solved, thanks for reporting!
> tag s:radio does not support dynamic attributes
> -----------------------------------------------
>
> Key: WW-3804
> URL: https://issues.apache.org/jira/browse/WW-3804
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - Tags
> Affects Versions: 2.3.3
> Reporter: Jose L Martinez-Avial
> Assignee: Lukasz Lenart
> Priority: Minor
> Labels: dynamic, tag
> Fix For: 2.3.5
>
>
> The tag s:radio does not support dynamic attributes. As a result, integration with javascript frameworks like Dojo does not work (it's not possible to setup the attribute dojoType or data-dojo-type)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (WW-3804) tag s:radio does not support dynamic
attributes
Posted by "Lukasz Lenart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lukasz Lenart reopened WW-3804:
-------------------------------
> tag s:radio does not support dynamic attributes
> -----------------------------------------------
>
> Key: WW-3804
> URL: https://issues.apache.org/jira/browse/WW-3804
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - Tags
> Affects Versions: 2.3.3
> Reporter: Jose L Martinez-Avial
> Assignee: Lukasz Lenart
> Priority: Minor
> Labels: dynamic, tag
> Fix For: 2.3.5
>
>
> The tag s:radio does not support dynamic attributes. As a result, integration with javascript frameworks like Dojo does not work (it's not possible to setup the attribute dojoType or data-dojo-type)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3804) tag s:radio does not support dynamic
attributes
Posted by "Jon Moores (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400478#comment-13400478 ]
Jon Moores commented on WW-3804:
--------------------------------
I havent run the test locally but I updated my struts jars to the new version and added the html below to my page:
<tr>
<td class="tdLabel"><label for="myname" class="label">mylabel:</label></td>
<td>
<s:radio name="myname" id="mynamehello" value="hello" list="#{'ALL': 'All Instructions'}" dojo="checked:hello"/><label for="mynamehello">world</label>
<s:radio name="myname" id="mynamefoo" list="#{'ALL': 'All Instructions'}" value="foo" dojo="checked:foo"/><label for="mynamefoo">bar</label>
</td>
</tr>
and I get the error. Also the docs for 2.3.4 explicitly say 'dynamic attributes allowed: false'
Error Message:
JSPG0227E: Exception caught while translating /tradingCentre/fund_orders.jsp: /tradingCentre/fund_orders.jsp(54,9) --> JSPG0123E: Unable to locate tag attribute info for tag attribute dojo.
> tag s:radio does not support dynamic attributes
> -----------------------------------------------
>
> Key: WW-3804
> URL: https://issues.apache.org/jira/browse/WW-3804
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - Tags
> Affects Versions: 2.3.3
> Reporter: Jose L Martinez-Avial
> Assignee: Lukasz Lenart
> Priority: Minor
> Labels: dynamic, tag
> Fix For: 2.3.4
>
>
> The tag s:radio does not support dynamic attributes. As a result, integration with javascript frameworks like Dojo does not work (it's not possible to setup the attribute dojoType or data-dojo-type)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3804) tag s:radio does not support dynamic
attributes
Posted by "Jose L Martinez-Avial (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258256#comment-13258256 ]
Jose L Martinez-Avial commented on WW-3804:
-------------------------------------------
well, just a quick question. When using HTML5 attributes (like data-dojo-props), would it be possible to use OGNL expression inside the value of the attribute. For example:
<s:radio name="myRadio" list"myRadioList" data-dojo-type="dijit.form.RadioButton" data-dojo-props="checked: %{isChecked};"/>
where %{isChecked} would be resovled against the vs. So, basically, it is possible to mix strings and ognl expression on the value?
> tag s:radio does not support dynamic attributes
> -----------------------------------------------
>
> Key: WW-3804
> URL: https://issues.apache.org/jira/browse/WW-3804
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - Tags
> Affects Versions: 2.3.3
> Reporter: Jose L Martinez-Avial
> Assignee: Lukasz Lenart
> Priority: Minor
> Labels: dynamic, tag
> Fix For: 2.3.4
>
>
> The tag s:radio does not support dynamic attributes. As a result, integration with javascript frameworks like Dojo does not work (it's not possible to setup the attribute dojoType or data-dojo-type)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WW-3804) tag s:radio does not support dynamic
attributes
Posted by "Lukasz Lenart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lukasz Lenart updated WW-3804:
------------------------------
Fix Version/s: (was: 2.3.4)
2.3.5
> tag s:radio does not support dynamic attributes
> -----------------------------------------------
>
> Key: WW-3804
> URL: https://issues.apache.org/jira/browse/WW-3804
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - Tags
> Affects Versions: 2.3.3
> Reporter: Jose L Martinez-Avial
> Assignee: Lukasz Lenart
> Priority: Minor
> Labels: dynamic, tag
> Fix For: 2.3.5
>
>
> The tag s:radio does not support dynamic attributes. As a result, integration with javascript frameworks like Dojo does not work (it's not possible to setup the attribute dojoType or data-dojo-type)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WW-3804) tag s:radio does not support dynamic
attributes
Posted by "Lukasz Lenart (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lukasz Lenart updated WW-3804:
------------------------------
Fix Version/s: 2.3.4
Any specific needs ? I've added dynamic attributes support for s:radio tag and changed a bit logic for value to use ValueStack to look for a value or the use original value.
> tag s:radio does not support dynamic attributes
> -----------------------------------------------
>
> Key: WW-3804
> URL: https://issues.apache.org/jira/browse/WW-3804
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - Tags
> Affects Versions: 2.3.3
> Reporter: Jose L Martinez-Avial
> Priority: Minor
> Labels: dynamic, tag
> Fix For: 2.3.4
>
>
> The tag s:radio does not support dynamic attributes. As a result, integration with javascript frameworks like Dojo does not work (it's not possible to setup the attribute dojoType or data-dojo-type)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3804) tag s:radio does not support dynamic
attributes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419861#comment-13419861 ]
Hudson commented on WW-3804:
----------------------------
Integrated in Struts2 #504 (See [https://builds.apache.org/job/Struts2/504/])
WW-3804 enables Radio tag to use dynamic attributes (Revision 1364090)
Result = FAILURE
lukaszlenart :
Files :
* /struts/struts2/trunk/core/src/main/java/org/apache/struts2/components/Head.java
* /struts/struts2/trunk/core/src/main/java/org/apache/struts2/components/Radio.java
* /struts/struts2/trunk/core/src/site/resources/tags/head.html
* /struts/struts2/trunk/core/src/site/resources/tags/radio.html
> tag s:radio does not support dynamic attributes
> -----------------------------------------------
>
> Key: WW-3804
> URL: https://issues.apache.org/jira/browse/WW-3804
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - Tags
> Affects Versions: 2.3.3
> Reporter: Jose L Martinez-Avial
> Assignee: Lukasz Lenart
> Priority: Minor
> Labels: dynamic, tag
> Fix For: 2.3.5
>
>
> The tag s:radio does not support dynamic attributes. As a result, integration with javascript frameworks like Dojo does not work (it's not possible to setup the attribute dojoType or data-dojo-type)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira