[jira] [Commented] (HDFS-16042) DatanodeAdminMonitor scan should be delay based

["Ahmed Hussein (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-16042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352535#comment-17352535 ] 

Ahmed Hussein commented on HDFS-16042:
--------------------------------------

Hey [~Jim_Brennan], can you please take a look at [GitHub Pull Request #3058|https://github.com/apache/hadoop/pull/3058]. It is pretty straightforward change.

> DatanodeAdminMonitor scan should be delay based
> -----------------------------------------------
>
>                 Key: HDFS-16042
>                 URL: https://issues.apache.org/jira/browse/HDFS-16042
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>            Reporter: Ahmed Hussein
>            Assignee: Ahmed Hussein
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> In {{DatanodeAdminManager.activate()}}, the Monitor task is scheduled with a fixed rate, ie. the period is from start1 -> start2.  
> {code:java}
> executor.scheduleAtFixedRate(monitor, intervalSecs, intervalSecs,
>    TimeUnit.SECONDS);
> {code}
> According to Java API docs for {{scheduleAtFixedRate}},
> {quote}If any execution of this task takes longer than its period, then subsequent executions may start late, but will not concurrently execute.{quote}
> It should be a fixed delay so it's end1 -> start1.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org