[GitHub] [accumulo] cshannon commented on a diff in pull request #3502: StoredTabletFile should lazy load ReferencedTabletFile

["cshannon (via GitHub)" <gi...@apache.org>]

cshannon commented on code in PR #3502:
URL: https://github.com/apache/accumulo/pull/3502#discussion_r1232392823


##########
core/src/main/java/org/apache/accumulo/core/metadata/StoredTabletFile.java:
##########
@@ -46,7 +49,7 @@ public class StoredTabletFile extends AbstractTabletFile<StoredTabletFile> {
   public StoredTabletFile(String metadataEntry) {
     super(new Path(metadataEntry));
     this.metadataEntry = metadataEntry;

Review Comment:
   Well (in theory) we should be only ever be passing in a String that was read from metadata so that means it was already stored before so it should not need validation as it would have already passed validation when stored originally. 
   
   When we store new files the metadata gets generated from the[ insert() ](https://github.com/apache/accumulo/blob/6a1431b773c49f422e109268dccd460661d5e02f/core/src/main/java/org/apache/accumulo/core/metadata/ReferencedTabletFile.java#L114)method of ReferencedTabletFile.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org