You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Haijie Hong (Code Review)" <ge...@cloudera.org> on 2016/11/04 12:27:16 UTC
[kudu-CR] KUDU-100 enable the ability to use RLE for the int64 type
Haijie Hong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4946
Change subject: KUDU-100 enable the ability to use RLE for the int64 type
......................................................................
KUDU-100 enable the ability to use RLE for the int64 type
As suggested in https://gerrit.cloudera.org/#/c/4822/, I modified code in cfile with a test.
Change-Id: I36ca437fcf0c98b3d79f7c07d72c1a7e61ff6a2f
---
M src/kudu/cfile/cfile-test-base.h
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/type_encodings.cc
M src/kudu/util/bit-util.h
4 files changed, 44 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/4946/1
--
To view, visit http://gerrit.cloudera.org:8080/4946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I36ca437fcf0c98b3d79f7c07d72c1a7e61ff6a2f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Haijie Hong <ho...@gmail.com>
[kudu-CR] KUDU-100 enable the ability to use RLE for the int64 type
Posted by "Haijie Hong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4946
to look at the new patch set (#4).
Change subject: KUDU-100 enable the ability to use RLE for the int64 type
......................................................................
KUDU-100 enable the ability to use RLE for the int64 type
As suggested in https://gerrit.cloudera.org/#/c/4822/, I modified code in cfile with a test.
Change-Id: I36ca437fcf0c98b3d79f7c07d72c1a7e61ff6a2f
---
M src/kudu/cfile/cfile-test-base.h
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/encoding-test.cc
M src/kudu/cfile/type_encodings.cc
M src/kudu/util/bit-util.h
5 files changed, 55 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/4946/4
--
To view, visit http://gerrit.cloudera.org:8080/4946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I36ca437fcf0c98b3d79f7c07d72c1a7e61ff6a2f
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Haijie Hong <ho...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-100 enable the ability to use RLE for the int64 type
Posted by "Haijie Hong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4946
to look at the new patch set (#5).
Change subject: KUDU-100 enable the ability to use RLE for the int64 type
......................................................................
KUDU-100 enable the ability to use RLE for the int64 type
As suggested in https://gerrit.cloudera.org/#/c/4822/, I modified code in cfile with a test.
Change-Id: I36ca437fcf0c98b3d79f7c07d72c1a7e61ff6a2f
---
M src/kudu/cfile/cfile-test-base.h
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/encoding-test.cc
M src/kudu/cfile/type_encodings.cc
M src/kudu/util/bit-util.h
5 files changed, 55 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/4946/5
--
To view, visit http://gerrit.cloudera.org:8080/4946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I36ca437fcf0c98b3d79f7c07d72c1a7e61ff6a2f
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Haijie Hong <ho...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-100 enable the ability to use RLE for the int64 type
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: KUDU-100 enable the ability to use RLE for the int64 type
......................................................................
KUDU-100 enable the ability to use RLE for the int64 type
As suggested in https://gerrit.cloudera.org/#/c/4822/, I modified code in cfile with a test.
Change-Id: I36ca437fcf0c98b3d79f7c07d72c1a7e61ff6a2f
Reviewed-on: http://gerrit.cloudera.org:8080/4946
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/cfile/cfile-test-base.h
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/encoding-test.cc
M src/kudu/cfile/type_encodings.cc
M src/kudu/util/bit-util.h
5 files changed, 49 insertions(+), 7 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I36ca437fcf0c98b3d79f7c07d72c1a7e61ff6a2f
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Haijie Hong <ho...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-100 enable the ability to use RLE for the int64 type
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-100 enable the ability to use RLE for the int64 type
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36ca437fcf0c98b3d79f7c07d72c1a7e61ff6a2f
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Haijie Hong <ho...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-100 enable the ability to use RLE for the int64 type
Posted by "Haijie Hong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4946
to look at the new patch set (#3).
Change subject: KUDU-100 enable the ability to use RLE for the int64 type
......................................................................
KUDU-100 enable the ability to use RLE for the int64 type
As suggested in https://gerrit.cloudera.org/#/c/4822/, I modified code in cfile with a test.
Change-Id: I36ca437fcf0c98b3d79f7c07d72c1a7e61ff6a2f
---
M src/kudu/cfile/cfile-test-base.h
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/encoding-test.cc
M src/kudu/cfile/type_encodings.cc
M src/kudu/util/bit-util.h
5 files changed, 55 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/4946/3
--
To view, visit http://gerrit.cloudera.org:8080/4946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I36ca437fcf0c98b3d79f7c07d72c1a7e61ff6a2f
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Haijie Hong <ho...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-100 enable the ability to use RLE for the int64 type
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-100 enable the ability to use RLE for the int64 type
......................................................................
Patch Set 1:
(2 comments)
Can you also edit encoding-test to add a test for int64s? it has 'TestIntBlockRoundTrip' which also includes support for generating runs. You'll also need to change the random() call in that function to generate 64-bit numbers (random() returns only 32-bit random integers). We have a different RNG available in util/random.h that you could use (it has a function for generating 64-bit rands i think)
http://gerrit.cloudera.org:8080/#/c/4946/1/src/kudu/cfile/cfile-test-base.h
File src/kudu/cfile/cfile-test-base.h:
Line 221: return value * 10;
this will never generate any integers which use all 64 bits. I think multiplying by some large number like 0x123456789abcdefLL in order to fill out all the bits would probably be a good idea.
Line 230: return (value * 10) *(value % 2 == 0 ? -1 : 1);
same
--
To view, visit http://gerrit.cloudera.org:8080/4946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36ca437fcf0c98b3d79f7c07d72c1a7e61ff6a2f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Haijie Hong <ho...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-100 enable the ability to use RLE for the int64 type
Posted by "Haijie Hong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4946
to look at the new patch set (#2).
Change subject: KUDU-100 enable the ability to use RLE for the int64 type
......................................................................
KUDU-100 enable the ability to use RLE for the int64 type
As suggested in https://gerrit.cloudera.org/#/c/4822/, I modified code in cfile with a test.
Change-Id: I36ca437fcf0c98b3d79f7c07d72c1a7e61ff6a2f
---
M src/kudu/cfile/cfile-test-base.h
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/encoding-test.cc
M src/kudu/cfile/type_encodings.cc
M src/kudu/util/bit-util.h
5 files changed, 54 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/4946/2
--
To view, visit http://gerrit.cloudera.org:8080/4946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I36ca437fcf0c98b3d79f7c07d72c1a7e61ff6a2f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Haijie Hong <ho...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-100 enable the ability to use RLE for the int64 type
Posted by "Haijie Hong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4946
to look at the new patch set (#6).
Change subject: KUDU-100 enable the ability to use RLE for the int64 type
......................................................................
KUDU-100 enable the ability to use RLE for the int64 type
As suggested in https://gerrit.cloudera.org/#/c/4822/, I modified code in cfile with a test.
Change-Id: I36ca437fcf0c98b3d79f7c07d72c1a7e61ff6a2f
---
M src/kudu/cfile/cfile-test-base.h
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/encoding-test.cc
M src/kudu/cfile/type_encodings.cc
M src/kudu/util/bit-util.h
5 files changed, 49 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/4946/6
--
To view, visit http://gerrit.cloudera.org:8080/4946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I36ca437fcf0c98b3d79f7c07d72c1a7e61ff6a2f
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Haijie Hong <ho...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>