[GitHub] [superset] villebro commented on a change in pull request #12229: refactor: New Icon system with Enhanced Antd Custom Icon

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #12229:
URL: https://github.com/apache/superset/pull/12229#discussion_r580233808



##########
File path: superset-frontend/src/components/Icons/index.ts
##########
@@ -0,0 +1,284 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { ReactComponent as AlertIcon } from 'images/icons/alert.svg';
+import { ReactComponent as AlertSolidIcon } from 'images/icons/alert_solid.svg';
+import { ReactComponent as AlertSolidSmallIcon } from 'images/icons/alert_solid_small.svg';
+import { ReactComponent as BinocularsIcon } from 'images/icons/binoculars.svg';
+import { ReactComponent as BoltIcon } from 'images/icons/bolt.svg';
+import { ReactComponent as BoltSmallIcon } from 'images/icons/bolt_small.svg';
+import { ReactComponent as BoltSmallRunIcon } from 'images/icons/bolt_small_run.svg';
+import { ReactComponent as CalendarIcon } from 'images/icons/calendar.svg';
+import { ReactComponent as CancelIcon } from 'images/icons/cancel.svg';
+import { ReactComponent as CancelSolidIcon } from 'images/icons/cancel_solid.svg';
+import { ReactComponent as CancelXIcon } from 'images/icons/cancel-x.svg';
+import { ReactComponent as CardViewIcon } from 'images/icons/card_view.svg';
+import { ReactComponent as CardsIcon } from 'images/icons/cards.svg';
+import { ReactComponent as CardsLockedIcon } from 'images/icons/cards_locked.svg';
+import { ReactComponent as CaretDownIcon } from 'images/icons/caret_down.svg';
+import { ReactComponent as CaretLeftIcon } from 'images/icons/caret_left.svg';
+import { ReactComponent as CaretRightIcon } from 'images/icons/caret_right.svg';
+import { ReactComponent as CaretUpIcon } from 'images/icons/caret_up.svg';
+import { ReactComponent as CertifiedIcon } from 'images/icons/certified.svg';
+import { ReactComponent as CheckIcon } from 'images/icons/check.svg';
+import { ReactComponent as CheckboxHalfIcon } from 'images/icons/checkbox-half.svg';
+import { ReactComponent as CheckboxOffIcon } from 'images/icons/checkbox-off.svg';
+import { ReactComponent as CheckboxOnIcon } from 'images/icons/checkbox-on.svg';
+import { ReactComponent as CircleCheckIcon } from 'images/icons/circle_check.svg';
+import { ReactComponent as CircleCheckSolidIcon } from 'images/icons/circle_check_solid.svg';
+import { ReactComponent as CircleIcon } from 'images/icons/circle.svg';
+import { ReactComponent as ClockIcon } from 'images/icons/clock.svg';
+import { ReactComponent as CloseIcon } from 'images/icons/close.svg';
+import { ReactComponent as CodeIcon } from 'images/icons/code.svg';
+import { ReactComponent as CogIcon } from 'images/icons/cog.svg';
+import { ReactComponent as CollapseIcon } from 'images/icons/collapse.svg';
+import { ReactComponent as ColorPaletteIcon } from 'images/icons/color_palette.svg';
+import { ReactComponent as ComponentsIcon } from 'images/icons/components.svg';
+import { ReactComponent as CopyIcon } from 'images/icons/copy.svg';
+import { ReactComponent as CursorTargeIcon } from 'images/icons/cursor_target.svg';
+import { ReactComponent as DatabaseIcon } from 'images/icons/database.svg';
+import { ReactComponent as DatasetPhysicalIcon } from 'images/icons/dataset_physical.svg';
+import { ReactComponent as DatasetVirtualGreyscaleIcon } from 'images/icons/dataset_virtual_greyscale.svg';
+import { ReactComponent as DatasetVirtualIcon } from 'images/icons/dataset_virtual.svg';
+import { ReactComponent as DownloadIcon } from 'images/icons/download.svg';
+import { ReactComponent as EditAltIcon } from 'images/icons/edit_alt.svg';
+import { ReactComponent as EditIcon } from 'images/icons/edit.svg';
+import { ReactComponent as EmailIcon } from 'images/icons/email.svg';
+import { ReactComponent as ErrorIcon } from 'images/icons/error.svg';
+import { ReactComponent as ErrorSolidIcon } from 'images/icons/error_solid.svg';
+import { ReactComponent as ErrorSolidSmallIcon } from 'images/icons/error_solid_small.svg';
+import { ReactComponent as ExclamationIcon } from 'images/icons/exclamation.svg';
+import { ReactComponent as ExpandIcon } from 'images/icons/expand.svg';
+import { ReactComponent as EyeIcon } from 'images/icons/eye.svg';
+import { ReactComponent as EyeSlashIcon } from 'images/icons/eye_slash.svg';
+import { ReactComponent as FavoriteSelectedIcon } from 'images/icons/favorite-selected.svg';
+import { ReactComponent as FavoriteSmallSelectedIcon } from 'images/icons/favorite_small_selected.svg';
+import { ReactComponent as FavoriteUnselectedIcon } from 'images/icons/favorite-unselected.svg';
+import { ReactComponent as FieldABCIcon } from 'images/icons/field_abc.svg';
+import { ReactComponent as FieldBooleanIcon } from 'images/icons/field_boolean.svg';
+import { ReactComponent as FieldDateIcon } from 'images/icons/field_date.svg';
+import { ReactComponent as FieldDerivedIcon } from 'images/icons/field_derived.svg';
+import { ReactComponent as FieldNumIcon } from 'images/icons/field_num.svg';
+import { ReactComponent as FieldStructIcon } from 'images/icons/field_struct.svg';
+import { ReactComponent as FileIcon } from 'images/icons/file.svg';
+import { ReactComponent as FilterIcon } from 'images/icons/filter.svg';
+import { ReactComponent as FilterSmallIcon } from 'images/icons/filter_small.svg';
+import { ReactComponent as FolderIcon } from 'images/icons/folder.svg';
+import { ReactComponent as FullIcon } from 'images/icons/full.svg';
+import { ReactComponent as FunctionIcon } from 'images/icons/function_x.svg';
+import { ReactComponent as GearIcon } from 'images/icons/gear.svg';
+import { ReactComponent as GridIcon } from 'images/icons/grid.svg';
+import { ReactComponent as ImageIcon } from 'images/icons/image.svg';
+import { ReactComponent as ImportIcon } from 'images/icons/import.svg';
+import { ReactComponent as InfoIcon } from 'images/icons/info.svg';
+import { ReactComponent as InfoSolidIcon } from 'images/icons/info-solid.svg';
+import { ReactComponent as InfoSolidSmallIcon } from 'images/icons/info_solid_small.svg';
+import { ReactComponent as JoinIcon } from 'images/icons/join.svg';
+import { ReactComponent as KeyboardIcon } from 'images/icons/keyboard.svg';
+import { ReactComponent as LayersIcon } from 'images/icons/layers.svg';
+import { ReactComponent as LightbulbIcon } from 'images/icons/lightbulb.svg';
+import { ReactComponent as LinkIcon } from 'images/icons/link.svg';
+import { ReactComponent as ListIcon } from 'images/icons/list.svg';
+import { ReactComponent as ListViewIcon } from 'images/icons/list_view.svg';
+import { ReactComponent as LocationIcon } from 'images/icons/location.svg';
+import { ReactComponent as LockLockedIcon } from 'images/icons/lock_locked.svg';
+import { ReactComponent as LockUnlockedIcon } from 'images/icons/lock_unlocked.svg';
+import { ReactComponent as MapIcon } from 'images/icons/map.svg';
+import { ReactComponent as MessageIcon } from 'images/icons/message.svg';
+import { ReactComponent as MinusIcon } from 'images/icons/minus.svg';
+import { ReactComponent as MinusSolidIcon } from 'images/icons/minus_solid.svg';
+import { ReactComponent as ModeHorizIcon } from 'images/icons/more_horiz.svg';

Review comment:
       nit: this should probably be `MoreHorizIcon`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org