[GitHub] [spark] yikf commented on a change in pull request #31664: [SPARK-34541][CORE] Fixed an issue where data could not be cleaned up when unregisterShuffle.

[GitBox <gi...@apache.org>]

yikf commented on a change in pull request #31664:
URL: https://github.com/apache/spark/pull/31664#discussion_r584384912



##########
File path: core/src/test/scala/org/apache/spark/shuffle/sort/SortShuffleManagerSuite.scala
##########
@@ -131,4 +139,29 @@ class SortShuffleManagerSuite extends SparkFunSuite with Matchers {
     )))
   }
 
+  test("Data could not be cleaned up when unregisterShuffle") {

Review comment:
       It seems that A and B are the same, both increasing from 0. I don't understand why the protocol should be differentiated on the write side




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org