[GitHub] [systemds] Baunsgaard commented on a diff in pull request #1848: [SYSTEMDS-3426] Python NN Builtin components

["Baunsgaard (via GitHub)" <gi...@apache.org>]

Baunsgaard commented on code in PR #1848:
URL: https://github.com/apache/systemds/pull/1848#discussion_r1257961714


##########
src/main/python/tests/nn/test_relu.py:
##########
@@ -37,29 +34,40 @@ class TestRelu(unittest.TestCase):
     @classmethod
     def setUpClass(cls):
         cls.sds = SystemDSContext()
+        cls.X = np.array([0, -1, -2, 2, 3, -5])
+        cls.dout = np.array([0, 1, 2, 3, 4, 5])
 
     @classmethod
     def tearDownClass(cls):
         cls.sds.close()
 
     def test_forward(self):
-        relu = ReLU()
-        #forward
-        Xm = self.sds.from_numpy(X)
+        relu = ReLU(self.sds)
+        # forward
+        Xm = self.sds.from_numpy(self.X)
         out = relu.forward(Xm).compute().flatten()

Review Comment:
   we need to update the strings to handle windows paths in the source command.
   
   I am guessing it can be fixed by adding an if here: https://github.com/apache/systemds/blob/f8acaab0c755dca0bf2e63c3f4d8279bc5effcaa/src/main/python/systemds/operator/nodes/source.py#L196C31-L196C40
   
   specifying if windows, then fix the path, else, do as it was before.
   
   Ideally we would like to fix it earlier, but this is a small hack for you to finish the task
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org