You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by th...@apache.org on 2017/04/06 01:55:26 UTC

tapestry-5 git commit: TAP5-2225: fixing test and fixing missing return in CoffeeScript.

Repository: tapestry-5
Updated Branches:
  refs/heads/5.4.x 6a49f8195 -> 2babc3bb8


TAP5-2225: fixing test and fixing missing return in CoffeeScript.

Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/2babc3bb
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/2babc3bb
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/2babc3bb

Branch: refs/heads/5.4.x
Commit: 2babc3bb8453ffaf951af08bff2b7c1798635c81
Parents: 6a49f81
Author: Thiago H. de Paula Figueiredo <th...@apache.org>
Authored: Wed Apr 5 22:55:10 2017 -0300
Committer: Thiago H. de Paula Figueiredo <th...@apache.org>
Committed: Wed Apr 5 22:55:10 2017 -0300

----------------------------------------------------------------------
 .../org/apache/tapestry5/t5-core-dom.coffee                     | 2 ++
 .../java/org/apache/tapestry5/integration/app1/AjaxTests.java   | 5 +++--
 2 files changed, 5 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/2babc3bb/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee b/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee
index ae29d8c..50a7cda 100644
--- a/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee
+++ b/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee
@@ -930,6 +930,8 @@ define ["underscore", "./utils", "./events", "jquery"],
         data = getDataAttributeAsObject(element, 'component-events')
         url = data?[eventName]?.url
         element = element.parentElement;
+    
+    return url;
 
   _.extend exports,
   

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/2babc3bb/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/AjaxTests.java
----------------------------------------------------------------------
diff --git a/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/AjaxTests.java b/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/AjaxTests.java
index 5bb9556..114e0f1 100644
--- a/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/AjaxTests.java
+++ b/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/AjaxTests.java
@@ -322,9 +322,10 @@ public class AjaxTests extends App1TestCase
         final String template = "//table/tbody/tr[%d]/td[%d]";
         
         for (int i = 1; i <= 8; i++) {
-            assertEquals("Row " + i, 
+            assertEquals(
                     getText(String.format(template, i, 3)),
-                    getText(String.format(template, i, 4)));
+                    getText(String.format(template, i, 4)),
+                    "Row " + i);
         }
 
 //        // An ugly way of giving time for all the AJAX requests to finish