You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by iskl <gi...@git.apache.org> on 2017/01/05 11:22:55 UTC
[GitHub] incubator-rocketmq pull request #29: [ROCKETMQ-31] Fix "No such file or dire...
GitHub user iskl opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/29
[ROCKETMQ-31] Fix "No such file or directory" warning for $HOME/rmq_b\u2026
The PR is to resolve the issue [ROCKETMQ-31](https://issues.apache.org/jira/browse/ROCKETMQ-31)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iskl/incubator-rocketmq ROCKETMQ-31
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/29.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #29
----
commit 619188cfa8c1e5d5ad21880154ab4fbac8fdb9d1
Author: kailai.skl <ka...@alipay.com>
Date: 2017-01-05T11:10:13Z
[ROCKETMQ-31] Fix "No such file or directory" warning for $HOME/rmq_bk_gc.log
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #29: [ROCKETMQ-31] Fix "No such file or directory" ...
Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/29
It's our mistake. As @iskl says, we print gc logs to tmpfs in order to eliminate long time latency brought by disk I/O competition.
IMO, we can merge this PR at current state, and open another issue to discuss where to place GC logs. How about your advise? @shroman -:)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #29: [ROCKETMQ-31] Fix "No such file or directory" ...
Posted by shroman <gi...@git.apache.org>.
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/29
@zhouxinyu @iskl's concerns are valid indeed.
My major concern is the logs can be lost when the system crashes. I think it's a good idea to discuss it in another JIRA issue.
I will create a JIRA issue, if it's ok with you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #29: [ROCKETMQ-31] Fix "No such file or dire...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/29
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #29: [ROCKETMQ-31] Fix "No such file or directory" ...
Posted by shroman <gi...@git.apache.org>.
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/29
yes, I see, you want to reduce disk I/O by placing the file into `/dev/shm`.
Well, GC logging has a minimal overhead. And to get a high-performance broker, I would tune my JVM to get smaller GC pauses, which has much larger impact on the overall performance.
Also, is it ok not to persist your GC logs? Long-term logging is essential for analysis of the brokers' performance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #29: [ROCKETMQ-31] Fix "No such file or directory" ...
Posted by shroman <gi...@git.apache.org>.
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/29
I would fix `-Xloggc:/dev/shm/mq_gc_%p.log` to point to `$HOME` instead of removing these two lines ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #29: [ROCKETMQ-31] Fix "No such file or directory" ...
Posted by stevenschew <gi...@git.apache.org>.
Github user stevenschew commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/29
it's good idea, review ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #29: [ROCKETMQ-31] Fix "No such file or directory" ...
Posted by shroman <gi...@git.apache.org>.
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/29
@zhouxinyu @stevenschew Thanks, guys, https://issues.apache.org/jira/browse/ROCKETMQ-36 is created to consider the improvement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #29: [ROCKETMQ-31] Fix "No such file or directory" ...
Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/29
@shroman it's ok surely.
Please @lizhanhui @stevenschew help review this pr.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #29: [ROCKETMQ-31] Fix "No such file or directory" ...
Posted by iskl <gi...@git.apache.org>.
Github user iskl commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/29
Dear @shroman , thanks for your suggestion :)
In my concept, broker thread is **time sensitive**. When broker thread in a MQ broker is in I/O operation and GC occurs, an **I/O competition** appears between broker thread and GC thread. It may bring **long time latency to broker thread**.
Linux distributions based on the 2.6 kernel and later offer `/dev/shm` as shared memory in the form of a **RAM disk** [(link)](https://en.wikipedia.org/wiki/Shared_memory). Pointing GC log to `/dev/shm` can avoid I/O competition between broker thread and GC thread.
In conclusion, I tend to use `-Xloggc:/dev/shm/mq_gc_%p.log` :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---