[jira] [Commented] (AIRFLOW-3632) dag_runs endpoint does not allow quick subsequent requests to same DAG

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-3632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734771#comment-16734771 ] 

ASF GitHub Bot commented on AIRFLOW-3632:
-----------------------------------------

alpeshpandya commented on pull request #4437: AIRFLOW-3632 Adding replace_microseconds parameter to dag_runs endpoint
URL: https://github.com/apache/incubator-airflow/pull/4437
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3632
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [x] Adding replace_microseconds parameter to dag_runs (trigger_dag) api allows user/scripts to submit run requests to Airflow without having to wait for one second for subsequent submission.
   Example of submitting with replace_microseconds parameter set to No:
   curl -X POST \
     http://localhost:8080/api/experimental/dags/example_bash_operator/dag_runs \
     -H 'Content-Type: application/json' \
     -H 'cache-control: no-cache' \
     -d '{"conf":"", "replace_microseconds":"N"}'
   
   The Parameter is still optional so not passing is interpreted as replace_microseconds Yes following convention of underlying trigger_dag method.
   
   ### Tests
   
   - [x] My PR does not need testing as there are no existing test cases for existing end points. The underlying trigger_dag method is not changed which is covered by existing test cases.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> dag_runs endpoint does not allow quick subsequent requests to same DAG
> ----------------------------------------------------------------------
>
>                 Key: AIRFLOW-3632
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3632
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: api
>    Affects Versions: 1.10.1
>         Environment: MacOS and Linux
>            Reporter: Alpesh
>            Assignee: Alpesh
>            Priority: Major
>              Labels: easyfix
>         Attachments: test_api.sh
>
>
> The experimental API endpoint to start dag runs (/dags/<string:dag_id>/dag_runs) does not allow quick subsequent requests to run same dag as trigger_dag controller method does not pass replace_microseconds argument to trigger_dag method of common/experimental/trigger_dag.py.
> The attached shell script runs example_bash_operator in quick successions. Only first request is accepted and subsequent requests are rejected with message "Run id manual__xxxxxx already exists for dag id example_bash_operator"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)