You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by audreyso <gi...@git.apache.org> on 2017/10/20 21:18:35 UTC
[GitHub] cordova-lib pull request #599: CB-13463 : prevent package.json update with -...
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/599
CB-13463 : prevent package.json update with --nosave (for plugins)
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
Prevent package.json update with --nosave (for plugins)
### What testing has been done on this change?
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/audreyso/cordova-lib CB-13463
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/599.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #599
----
commit 2226a21bccf6a77f007777ba8bdbd45c59667990
Author: Audrey So <au...@apache.org>
Date: 2017-10-20T21:10:26Z
CB-13463 : prevent package.json update plugins with --nosave
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #599: CB-13463 : prevent package.json update with -...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/599
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #599: CB-13463 : prevent package.json update with --nosave...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/599
LGTM, but the ci failures 😨
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #599: CB-13463 : prevent package.json update with --nosave...
Posted by audreyso <gi...@git.apache.org>.
Github user audreyso commented on the issue:
https://github.com/apache/cordova-lib/pull/599
@stevengill CI is passing now. Let me know if I should merge it in!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #599: CB-13463 : prevent package.json update with --nosave...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/599
merge!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org