[GitHub] [geode] jhuynh1 opened pull request #4531: [WIP] Removed unused wait parameter

["jhuynh1 (GitHub)" <gi...@apache.org>]

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/4531 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jhuynh1 closed pull request #4531: GEODE-7659: Removed unused wait parameter, fixed test listener pollution

["jhuynh1 (GitHub)" <gi...@apache.org>]

[ pull request closed by jhuynh1 ]

[ Full content available at: https://github.com/apache/geode/pull/4531 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] nabarunnag commented on pull request #4531: GEODE-7659: Removed unused wait parameter, fixed test listener pollution

["nabarunnag (GitHub)" <gi...@apache.org>]

Same here: Should the getTestMethodName() be modified to getUniqueName()

[ Full content available at: https://github.com/apache/geode/pull/4531 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] nabarunnag commented on pull request #4531: GEODE-7659: Removed unused wait parameter, fixed test listener pollution

["nabarunnag (GitHub)" <gi...@apache.org>]

According to the code, this method is not used anywhere but in a few commented out section. Do we need to remove them?

[ Full content available at: https://github.com/apache/geode/pull/4531 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org