You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2023/05/26 07:54:26 UTC

[GitHub] [incubator-opendal] Xuanwo commented on pull request #2329: feat(bindings/C): opendal_operator_ptr construction using kvs

Xuanwo commented on PR #2329:
URL: https://github.com/apache/incubator-opendal/pull/2329#issuecomment-1563963426

   `opendal_kv` is not a good name to me as it confused with existing features inside opendal, so does `opendal_map`.
   
   How about API like the following:
   
   ```c
   struct opendal_operator_builder *options = opendal_operator_builder_new();
   opendal_operator_builder_set(options, "a", "x");
   opendal_operator_builder_set(options, "b", "y");
   opendal_operator_builder_set(options, "c", "z");
   opendal_operator_ptr ptr = opendal_operator_new(options);
   ```
   
   Can we implement the `move` semantic in Rust for freeing `opendal_operator_builder` in `opendal_operator_new`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org