You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/08/22 17:02:44 UTC

[GitHub] [incubator-druid] himanshug commented on issue #8303: Enable code coverage

himanshug commented on issue #8303: Enable code coverage
URL: https://github.com/apache/incubator-druid/pull/8303#issuecomment-523991331
 
 
   In https://github.com/apache/incubator-druid/pull/8359 coverage build failed due to drop by 0.09% (report says coverage of files not touched in the PR dropped)
   also in any case, do we really want to fail the overall build on code coverage drop of 0.09% .
   
   @clintropolis @gianm 
   while code coverage is an interesting metric , I don't think it is a metric to chase for and fail the builds.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org