You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2021/10/17 00:32:26 UTC

[GitHub] [daffodil-vscode] jw3 commented on a change in pull request #35: Change build settings to ensure repeatable builds

jw3 commented on a change in pull request #35:
URL: https://github.com/apache/daffodil-vscode/pull/35#discussion_r729890894



##########
File path: build.sbt
##########
@@ -18,7 +18,6 @@ lazy val daffodilVer = "3.1.0"
 
 lazy val commonSettings = {
   Seq(
-    git.useGitDescribe := true,

Review comment:
       Yeah, it should match the package.json version.
   
   A manual process of syncing those and a CI check that they match is sort of what we did before, only difference is now we will need to manually update both places.  It would be nice to only change it in one place, but I don't know of a straightforward way to do that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org