[jira] [Created] (SHINDIG-1989) RENDER_DEBUG is set incorrectly in the sample container (documentation wrong too)

["Doug Davies (JIRA)" <ji...@apache.org>]

Doug Davies created SHINDIG-1989:
------------------------------------

             Summary: RENDER_DEBUG is set incorrectly in the sample container (documentation wrong too)
                 Key: SHINDIG-1989
                 URL: https://issues.apache.org/jira/browse/SHINDIG-1989
             Project: Shindig
          Issue Type: Bug
          Components: Javascript 
    Affects Versions: 2.5.2
            Reporter: Doug Davies
            Priority: Minor


In commoncontainer renderDebug is set as follows

  testConfig[osapi.container.ContainerConfig.RENDER_DEBUG] = '0';

and then in container.js it does this

 this.renderDebug_ = (typeof param === 'undefined') ?
     Boolean(osapi.container.util.getSafeJsonValue(config,
         osapi.container.ContainerConfig.RENDER_DEBUG, false)) :
     (param === '1');

which sets this.renderDebug_ to TRUE (incorrectly).  I think the creation of the Boolean is only caring that the string has a value and setting to TRUE.

Is this a container/documentation error and we should fix the containers OR should the container.js code be able to handle the string?  Having renderDebug set to always true means that caching of requests will never be turned on.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)