[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1670: Support setting timeout for stream load

[GitBox <gi...@apache.org>]

EmmyMiao87 commented on a change in pull request #1670: Support setting timeout for stream load
URL: https://github.com/apache/incubator-doris/pull/1670#discussion_r315484539
 
 

 ##########
 File path: be/src/http/action/stream_load.cpp
 ##########
 @@ -238,6 +238,10 @@ Status StreamLoadAction::_on_header(HttpRequest* http_req, StreamLoadContext* ct
 
     TNetworkAddress master_addr = _exec_env->master_info()->network_address;
 
+    if (!http_req->header(HTTP_TIMEOUT).empty()) {
+        ctx->timeout_second = std::stoi(http_req->header(HTTP_TIMEOUT)); 
 
 Review comment:
   It will thrown the std::invalid_argument  exception which could not be catch in the out side.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org