You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/10/27 00:02:43 UTC

[GitHub] [beam] MiguelAnzoWizeline commented on pull request #15549: [BEAM-11997] Changed RedisIO implementation to SDF

MiguelAnzoWizeline commented on pull request #15549:
URL: https://github.com/apache/beam/pull/15549#issuecomment-952422475


   Hi @lukecwik 
   I made several changes to the implementation following the comments you made. The changes are working and the Read tests are passing correctly, however I would like some feedback to know if it implemented as intended by our previous conversation.
   Also the trySplit method is still missing, I'm unsure of how to implement the checkpoints, I left my idea of implementation commented, but trying to uncomment it provokes a failure in the tests, 1 missing item in the output, and I'm not sure of why yet.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org