[GitHub] [spark] zhengruifeng commented on a diff in pull request #38638: [SPARK-41122][CONNECT] Explain API can support different modes

[GitBox <gi...@apache.org>]

zhengruifeng commented on code in PR #38638:
URL: https://github.com/apache/spark/pull/38638#discussion_r1021002542


##########
connector/connect/src/main/protobuf/spark/connect/base.proto:
##########
@@ -48,6 +72,9 @@ message Request {
   // The logical plan to be executed / analyzed.
   Plan plan = 3;
 
+  // (Required) For analyzePlan rpc calls, configure the mode to explain plan in strings.
+  ExplainMode explain_mode= 4;

Review Comment:
   should we group the fields in `Request`?
   
   I notice that there are more methods seems should be placed in `AnalyzePlan`:
   
   - isLocal
   - isStreaming
   - inputFiles
   - semanticHash
   - catalog APIs (not sure about this)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org