[jira] [Commented] (OFBIZ-5497) last index for paging is not calculated correctly

["Gareth Carter (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-5497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878728#comment-13878728 ] 

Gareth Carter commented on OFBIZ-5497:
--------------------------------------

Excellent. Thanks Jacques.

I usually press that button, forgot this time.

That other jira sounds similar but not sure, depends if it uses the paging functionality.

Iv only seen 2 macros but 1 calls the other, are there more? I know atleast the renderNextPrev can be improved by removing the viewLastIndex as a parameter and calcuating the last page index in the macro itself. This will remove the need for any ftls to calculate it but I have only seen a few ftl files with this, the rest use form widget

> last index for paging is not calculated correctly
> -------------------------------------------------
>
>                 Key: OFBIZ-5497
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5497
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Gareth Carter
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 11.04, SVN trunk, Release Branch 12.04, Release Branch 13.07
>
>         Attachments: last_index.patch
>
>
> The last index (used on the last button) is not calculated correctly in ftl or the renderer classes. It currently users floor which works only for list sizes that are not multiples of the view size. When you have a list size which is a multiple of the view size, it does not subtract 1 for zero based index and therefore the last button goes to the last page + 1
> Examples
> listSize = 1
> viewSize = 10
> listSize / viewSize = 0.1
> floor(0.1) = 0
> This one produces the correct value
> listSize = 20
> viewSize = 10
> listSize / viewSize = 2
> floor(2) = 2
> Last index should be 1 because of zero based index but never occurs
> To reproduce, enter a view with a list and paging functionality, the list size must be a multiple of the view size



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)