[jira] [Commented] (PHOENIX-5274) ConnectionQueryServiceImpl#ensureNamespaceCreated and ensureTableCreated should use HBase APIs that do not require ADMIN permissions for existence checks

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349370#comment-17349370 ] 

Hadoop QA commented on PHOENIX-5274:
------------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  1s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} docker {color} | {color:red}  0m 22s{color} | {color:red} Dockerfile '/home/jenkins/jenkins-home/workspace/PreCommit-PHOENIX-Build/component/dev/docker/Dockerfile.yetus' not found. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | PHOENIX-5274 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12979899/PHOENIX-5274.4.x-HBase-1.5.v3.patch |
| Console output | https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/391/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |


This message was automatically generated.



> ConnectionQueryServiceImpl#ensureNamespaceCreated and ensureTableCreated should use HBase APIs that do not require ADMIN permissions for existence checks
> ---------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-5274
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5274
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 5.0.0, 4.15.0, 4.14.2
>            Reporter: Chinmay Kulkarni
>            Assignee: Ankit Jain
>            Priority: Major
>             Fix For: 4.17.0, 5.2.0, 5.1.2, 4.16.2
>
>         Attachments: PHOENIX-5274.4.x-HBase-1.5.v1.patch, PHOENIX-5274.4.x-HBase-1.5.v2.patch, PHOENIX-5274.4.x-HBase-1.5.v3.patch
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> [HBASE-22377|https://issues.apache.org/jira/browse/HBASE-22377] will introduce a new API that does not require ADMIN permissions to check the existence of a namespace.
> Currently, CQSI#ensureNamespaceCreated calls HBaseAdmin#getNamespaceDescriptor which eventually on the server causes a call to AccessController#preGetNamespaceDescriptor. This tries to acquire ADMIN permissions on the namespace. We should ideally use the new API provided by HBASE-22377 which does not require the phoenix client to get ADMIN permissions on the namespace. We should acquire ADMIN permissions only in case we need to create the namespace if it doesn't already exist.
> Similarly, CQSI#ensureTableCreated should first check the existence of a table before trying to do HBaseAdmin#getTableDescriptor since this requires CREATE and ADMIN permissions.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)