[GitHub] [superset] craig-rueda commented on a diff in pull request #21806: feat(helm): Support for flower and websocket containers

[GitBox <gi...@apache.org>]

craig-rueda commented on code in PR #21806:
URL: https://github.com/apache/superset/pull/21806#discussion_r997168166


##########
helm/superset/values.yaml:
##########
@@ -267,20 +267,18 @@ supersetNode:
   # -- If true, forces deployment to reload on each upgrade
   forceReload: false
   # -- Init containers
-  # @default -- a container waiting for postgres to be up
+  # @default -- a container waiting for postgres
   initContainers:
     - name: wait-for-postgres
-      image: "{{ .Values.initImage.repository }}:{{ .Values.initImage.tag }}"
-      imagePullPolicy: "{{ .Values.initImage.pullPolicy }}"
+      image: jwilder/dockerize

Review Comment:
   Shouldn't this be a reference to the config keys?



##########
helm/superset/values.yaml:
##########
@@ -267,20 +267,18 @@ supersetNode:
   # -- If true, forces deployment to reload on each upgrade
   forceReload: false
   # -- Init containers
-  # @default -- a container waiting for postgres to be up
+  # @default -- a container waiting for postgres
   initContainers:
     - name: wait-for-postgres
-      image: "{{ .Values.initImage.repository }}:{{ .Values.initImage.tag }}"
-      imagePullPolicy: "{{ .Values.initImage.pullPolicy }}"
+      image: jwilder/dockerize
+      imagePullPolicy: IfNotPresent

Review Comment:
   Same comment as above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org