You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "honeyhexin (Code Review)" <ge...@cloudera.org> on 2019/08/01 04:40:16 UTC
[kudu-CR] tools: fix warnning when compiling in ASAN and TSAN caused by ConvertToKuduPartialRow.
honeyhexin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13974
Change subject: tools: fix warnning when compiling in ASAN and TSAN caused by ConvertToKuduPartialRow.
......................................................................
tools: fix warnning when compiling in ASAN and TSAN caused by ConvertToKuduPartialRow.
This is a follow-up to 58e01492320f954cd1 to fix waring in compile log
when build type is TSAN or ASAN.
Change-Id: I6307be31e56ebe0999c82d3bb66f2823d6fb0d03
---
M src/kudu/tools/tool_action_table.cc
1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/13974/1
--
To view, visit http://gerrit.cloudera.org:8080/13974
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6307be31e56ebe0999c82d3bb66f2823d6fb0d03
Gerrit-Change-Number: 13974
Gerrit-PatchSet: 1
Gerrit-Owner: honeyhexin <ho...@sohu.com>
[kudu-CR] tools: fix warning when compiling in ASAN and TSAN caused by ConvertToKuduPartialRow.
Posted by "honeyhexin (Code Review)" <ge...@cloudera.org>.
honeyhexin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13974 )
Change subject: tools: fix warning when compiling in ASAN and TSAN caused by ConvertToKuduPartialRow.
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13974/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13974/1//COMMIT_MSG@7
PS1, Line 7: warning
> warning
Done
http://gerrit.cloudera.org:8080/#/c/13974/1//COMMIT_MSG@9
PS1, Line 9: warnin
> warning
Done
--
To view, visit http://gerrit.cloudera.org:8080/13974
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6307be31e56ebe0999c82d3bb66f2823d6fb0d03
Gerrit-Change-Number: 13974
Gerrit-PatchSet: 2
Gerrit-Owner: honeyhexin <ho...@sohu.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: honeyhexin <ho...@sohu.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 05:02:20 +0000
Gerrit-HasComments: Yes
[kudu-CR] tools: fix warnning when compiling in ASAN and TSAN caused by ConvertToKuduPartialRow.
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13974 )
Change subject: tools: fix warnning when compiling in ASAN and TSAN caused by ConvertToKuduPartialRow.
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13974/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13974/1//COMMIT_MSG@7
PS1, Line 7: warnning
warning
http://gerrit.cloudera.org:8080/#/c/13974/1//COMMIT_MSG@9
PS1, Line 9: waring
warning
--
To view, visit http://gerrit.cloudera.org:8080/13974
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6307be31e56ebe0999c82d3bb66f2823d6fb0d03
Gerrit-Change-Number: 13974
Gerrit-PatchSet: 1
Gerrit-Owner: honeyhexin <ho...@sohu.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 01 Aug 2019 04:48:14 +0000
Gerrit-HasComments: Yes
[kudu-CR] tools: fix warning when compiling in ASAN and TSAN caused by ConvertToKuduPartialRow.
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13974 )
Change subject: tools: fix warning when compiling in ASAN and TSAN caused by ConvertToKuduPartialRow.
......................................................................
tools: fix warning when compiling in ASAN and TSAN caused by ConvertToKuduPartialRow.
This is a follow-up to 58e01492320f954cd1 to fix warning in compile log
when build type is TSAN or ASAN.
Change-Id: I6307be31e56ebe0999c82d3bb66f2823d6fb0d03
Reviewed-on: http://gerrit.cloudera.org:8080/13974
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/tools/tool_action_table.cc
1 file changed, 7 insertions(+), 7 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13974
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6307be31e56ebe0999c82d3bb66f2823d6fb0d03
Gerrit-Change-Number: 13974
Gerrit-PatchSet: 3
Gerrit-Owner: honeyhexin <ho...@sohu.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: honeyhexin <ho...@sohu.com>
[kudu-CR] tools: fix warning when compiling in ASAN and TSAN caused by ConvertToKuduPartialRow.
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13974 )
Change subject: tools: fix warning when compiling in ASAN and TSAN caused by ConvertToKuduPartialRow.
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13974
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6307be31e56ebe0999c82d3bb66f2823d6fb0d03
Gerrit-Change-Number: 13974
Gerrit-PatchSet: 2
Gerrit-Owner: honeyhexin <ho...@sohu.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: honeyhexin <ho...@sohu.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 05:05:04 +0000
Gerrit-HasComments: No
[kudu-CR] tools: fix warning when compiling in ASAN and TSAN caused by ConvertToKuduPartialRow.
Posted by "honeyhexin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13974
to look at the new patch set (#2).
Change subject: tools: fix warning when compiling in ASAN and TSAN caused by ConvertToKuduPartialRow.
......................................................................
tools: fix warning when compiling in ASAN and TSAN caused by ConvertToKuduPartialRow.
This is a follow-up to 58e01492320f954cd1 to fix warning in compile log
when build type is TSAN or ASAN.
Change-Id: I6307be31e56ebe0999c82d3bb66f2823d6fb0d03
---
M src/kudu/tools/tool_action_table.cc
1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/13974/2
--
To view, visit http://gerrit.cloudera.org:8080/13974
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6307be31e56ebe0999c82d3bb66f2823d6fb0d03
Gerrit-Change-Number: 13974
Gerrit-PatchSet: 2
Gerrit-Owner: honeyhexin <ho...@sohu.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)