You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "chibenwa (via GitHub)" <gi...@apache.org> on 2023/03/13 06:33:41 UTC

[GitHub] [james-project] chibenwa opened a new pull request, #1479: JAMES-3891 Graceful shutdown for queue consumers [3.7.x]

chibenwa opened a new pull request, #1479:
URL: https://github.com/apache/james-project/pull/1479

   Graceful shutdown for scheduler is a late addition to the reactor framework, hence I propose an alternative to it.
   
   CF https://github.com/reactor/reactor-core/pull/3089


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] chibenwa merged pull request #1479: JAMES-3891 Graceful shutdown for queue consumers [3.7.x]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa merged PR #1479:
URL: https://github.com/apache/james-project/pull/1479


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] ottoka commented on pull request #1479: JAMES-3891 Graceful shutdown for queue consumers [3.7.x]

Posted by "ottoka (via GitHub)" <gi...@apache.org>.
ottoka commented on PR #1479:
URL: https://github.com/apache/james-project/pull/1479#issuecomment-1471470935

   That must be it, I just ran the entire webadmin-integration-test suite and all was fine. So is this CI issue going to block the 3.7.4 release?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] Arsnael commented on pull request #1479: JAMES-3891 Graceful shutdown for queue consumers [3.7.x]

Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #1479:
URL: https://github.com/apache/james-project/pull/1479#issuecomment-1471567950

   We did some fixes on the jenkins build following the CI chaotic upgrade... I just restarted your build, let's hope it goes better this time


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] vttranlina commented on a diff in pull request #1479: JAMES-3891 Graceful shutdown for queue consumers [3.7.x]

Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on code in PR #1479:
URL: https://github.com/apache/james-project/pull/1479#discussion_r1138367482


##########
server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/remote/delivery/DeliveryRunnable.java:
##########
@@ -204,6 +210,12 @@ private Duration getNextDelay(int retryCount) {
     @Override
     public void dispose() {
         disposable.dispose();
+
+        Awaitility.await()

Review Comment:
   Should we move it in try catch block?
   I worry after 2 seconds, it will throw an exception, 
   then the bellow code will not be run
   ```
    remoteDeliveryProcessScheduler.dispose();
    remoteDeliveryDequeueScheduler.dispose();
   ```
   
    



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] ottoka commented on pull request #1479: JAMES-3891 Graceful shutdown for queue consumers [3.7.x]

Posted by "ottoka (via GitHub)" <gi...@apache.org>.
ottoka commented on PR #1479:
URL: https://github.com/apache/james-project/pull/1479#issuecomment-1471427227

   I wonder about the test failures here. I did a quick test and locally all is well. So is this a matter of timing, test(suite) isolation, or an artifact of the CI build environment? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] chibenwa commented on pull request #1479: JAMES-3891 Graceful shutdown for queue consumers [3.7.x]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #1479:
URL: https://github.com/apache/james-project/pull/1479#issuecomment-1471435880

   Build is especially unstable lately due to recent ci update


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org