[GitHub] [openwhisk] style95 commented on a diff in pull request #5386: Add Scheduler Queue Metric for Not Processing Any Activations

["style95 (via GitHub)" <gi...@apache.org>]

style95 commented on code in PR #5386:
URL: https://github.com/apache/openwhisk/pull/5386#discussion_r1127247333


##########
core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/queue/MemoryQueue.scala:
##########
@@ -1201,6 +1207,13 @@ object MemoryQueue {
       logging.info(
         this,
         s"[$invocationNamespace:$action:$stateName] some activations are stale msg: ${queue.head.msg.activationId}.")
+      val currentTime = Instant.now.toEpochMilli
+      if (currentTime - lastActivationExecutedTime.get() > maxRetentionMs) {
+        MetricEmitter.emitGaugeMetric(
+          LoggingMarkers
+            .SCHEDULER_QUEUE_NOT_PROCESSING(invocationNamespace, action.asString, action.toStringWithoutVersion),

Review Comment:
   I agree with this PR.
   One question is if we collect the counter metrics here, what kinds of information we can get?
   Can we differentiate the case where an activation request does not arrive because there are not enough containers and the case where dangling containers make the system cannot handle activations?
   
   Do we also need to collect the counter of activation requests that actually got activations?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org