[jira] [Commented] (MRESOLVER-357) ConflictResolver STANDARD verbosity misbehaves

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MRESOLVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717632#comment-17717632 ] 

ASF GitHub Bot commented on MRESOLVER-357:
------------------------------------------

cstamas opened a new pull request, #283:
URL: https://github.com/apache/maven-resolver/pull/283

   The check was wrong, it was "has ANY sibling", while it should be "has ANY RELATED sibling".
   
   ---
   
   https://issues.apache.org/jira/browse/MRESOLVER-357




> ConflictResolver STANDARD verbosity misbehaves
> ----------------------------------------------
>
>                 Key: MRESOLVER-357
>                 URL: https://issues.apache.org/jira/browse/MRESOLVER-357
>             Project: Maven Resolver
>          Issue Type: Bug
>          Components: Resolver
>    Affects Versions: 1.9.8, 1.9.9
>            Reporter: Tamas Cservenak
>            Priority: Major
>             Fix For: 1.9.10
>
>
> As per use report, the 1.9.8 and 1.9.9 versions produce different "verbose tree" that previous versions:
> {noformat}
> Input node:
> some-group:a:jar:1.0 [compile]
> +- some-group:b:jar:1.0 [compile]
> |  +- some-group:c:jar:1.0 [compile]
> |  +- some-group:c:jar:2.0 [compile]
> |  \- some-group:d:jar:1.0 [compile]
> +- some-group:c:jar:2.0 [compile]
> +- some-group:c:jar:1.0 [compile]
> \- some-group:d:jar:2.0 [compile]
> Transformed node:
> some-group:a:jar:1.0 [compile]
> +- some-group:b:jar:1.0 [compile]
> |  \- some-group:c:jar:2.0 [compile] (nearer exists)
> +- some-group:c:jar:2.0 [compile]
> \- some-group:d:jar:2.0 [compile] {noformat}
> The {{some-group:d:jar:1.0 [compile]}} should not be removed.
> Seems that code comment "leaving only 1 loser" is present in comments only, but the actual code does not deliver this promise.
> In fact, the check is wrong: it should check for same GA child count and not ANY child count.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)