You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "sodonnel (via GitHub)" <gi...@apache.org> on 2023/10/27 16:26:39 UTC
[PR] HDDS-9557. Datanode should log Follower cannot close container at info level [ozone]
sodonnel opened a new pull request, #5506:
URL: https://github.com/apache/ozone/pull/5506
## What changes were proposed in this pull request?
When a datanode which is not the followed received a closed container command, if the pipeline is still active and the datanode is not the pipeline leader, the close fails with a NotLeaderException.
If the container is failing to close for some reason (eg [HDDS-3509](https://issues.apache.org/jira/browse/HDDS-3509)) then there are no clues in the DN log that it is failing to close the container.
We should log this at INFO level rather than debug.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9557
## How was this patch tested?
Logging only change - no tests modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9557. Datanode should log Follower cannot close container at info level [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5506:
URL: https://github.com/apache/ozone/pull/5506#issuecomment-1804431144
@sodonnel Was the single message being changed from debug to info enough to figure out the problem? Or did you use other debug-level messages in your investigation?
If it is enough to change only this message to make it much more useful, then +1 from me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9557. Datanode should log Follower cannot close container at info level [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5506:
URL: https://github.com/apache/ozone/pull/5506#issuecomment-1805331936
Thanks @sodonnel for the patch, @siddhantsangwan for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9557. Datanode should log Follower cannot close container at info level [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #5506:
URL: https://github.com/apache/ozone/pull/5506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9557. Datanode should log Follower cannot close container at info level [ozone]
Posted by "umamaheswararao (via GitHub)" <gi...@apache.org>.
umamaheswararao commented on PR #5506:
URL: https://github.com/apache/ozone/pull/5506#issuecomment-1785583944
@DaveTeng0 could you please take a look at it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9557. Datanode should log Follower cannot close container at info level [ozone]
Posted by "sodonnel (via GitHub)" <gi...@apache.org>.
sodonnel commented on PR #5506:
URL: https://github.com/apache/ozone/pull/5506#issuecomment-1804305876
@siddhantsangwan I don't think the logging will be overly excessive, and it is useful in debugging. I had a case where I could not find out why a container was not closing until I switch to debug logging which is fairly inconvenient.
Do you think we can commit this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org