You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "sureshanaparti (via GitHub)" <gi...@apache.org> on 2026/03/10 10:13:51 UTC

[PR] Fix NPE during VM setup for pvlan [cloudstack]

sureshanaparti opened a new pull request, #12781:
URL: https://github.com/apache/cloudstack/pull/12781

   ### Description
   
   This PR fixes NPE issue during VM setup for pvlan.
   
   `ERROR [c.c.v.VmWorkJobDispatcher] (Work-Job-Executor-5:[ctx-36c8ede2, job-51933/job-51934]) (logid:aad07025) Unable to complete AsyncJob {"accountId":2,"cmd":"com.cloud.vm.VmWorkMigrate","cmdInfo":"rO0ABXNyABpjb20uY2xvdWQudm0uVm1Xb3JrTWlncmF0ZRdxQXtPtzYqAgAGSgAJc3JjSG9zdElkTAAJY2x1c3RlcklkdAAQTGphdmEvbGFuZy9Mb25nO0wABmhvc3RJZHEAfgABTAAFcG9kSWRxAH4AAUwAB3N0b3JhZ2V0AA9MamF2YS91dGlsL01hcDtMAAZ6b25lSWRxAH4AAXhyABNjb20uY2xvdWQudm0uVm1Xb3Jrn5m2VvAlZ2sCAARKAAlhY2NvdW50SWRKAAZ1c2VySWRKAAR2bUlkTAALaGFuZGxlck5hbWV0ABJMamF2YS9sYW5nL1N0cmluZzt4cAAAAAAAAAACAAAAAAAAAFMAAAAAAAAAMHQAGVZpcnR1YWxNYWNoaW5lTWFuYWdlckltcGwAAAAAAAAAEXNyAA5qYXZhLmxhbmcuTG9uZzuL5JDMjyPfAgABSgAFdmFsdWV4cgAQamF2YS5sYW5nLk51bWJlcoaslR0LlOCLAgAAeHAAAAAAAAAAA3NxAH4ABwAAAAAAAAATc3EAfgAHAAAAAAAAAAFwcQB-AAs","cmdVersion":0,"completeMsid":null,"created":"Mon Feb 16 15:40:04 EST 2026","id":51934,"initMsid":90520733277145,"instanceId":null,"instanceType":null,"lastPolled":null,"lastUpdated":null,"processStatus":0,"removed":null,"r
 esult":null,"resultCode":0,"status":"IN_PROGRESS","userId":83,"uuid":"c3826ec3-3793-453c-bd0b-a79cbfbda7fe"}, job origin: 51933 java.lang.NullPointerException: Cannot invoke "java.net.URI.getScheme()" because the return value of "com.cloud.vm.NicProfile.getBroadCastUri()" is null at com.cloud.vm.UserVmManagerImpl.setupVmForPvlan(UserVmManagerImpl.java:5390) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:569) at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344) at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(Re
 flectiveMethodInvocation.java:163) at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186) at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215) at jdk.proxy3/jdk.proxy3.$Proxy219.setupVmForPvlan(Unknown Source) at org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.prepareNicForMigration(NetworkOrchestrator.java:2278) at com.cloud.vm.VirtualMachineManagerImpl.migrate(VirtualMachineManagerImpl.java:3100) at com.cloud.vm.VirtualMachineManagerImpl.orchestrateMigrate(VirtualMachineManagerImpl.java:3052) at com.cloud.vm.VirtualMachineManagerImpl.orchestrateMigrate(VirtualMachineManagerImpl.java:5978)`
   
   
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ******************************************************************************* -->
   <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ******************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] Build/CI
   - [ ] Test (unit or integration test code)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   ### Screenshots (if appropriate):
   
   ### How Has This Been Tested?
   
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   
   #### How did you try to break this feature and the system with this change?
   
   <!-- see how your change affects other areas of the code, etc. -->
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix NPE during VM setup for pvlan [cloudstack]

Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #12781:
URL: https://github.com/apache/cloudstack/pull/12781#issuecomment-4030232061

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix NPE during VM setup for pvlan [cloudstack]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #12781:
URL: https://github.com/apache/cloudstack/pull/12781#discussion_r2910863072


##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -5405,7 +5405,12 @@ public boolean finalizeVirtualMachineProfile(VirtualMachineProfile profile, Depl
 
     @Override
     public boolean setupVmForPvlan(boolean add, Long hostId, NicProfile nic) {
-        if (!nic.getBroadCastUri().getScheme().equals("pvlan")) {
+        if (nic == null || nic.getBroadCastUri() == null) {
+            return false;
+        }
+
+        String scheme = nic.getBroadCastUri().getScheme();
+        if (!"pvlan".equals(scheme)) {

Review Comment:
   Returning `false` here makes the failure mode indistinguishable from the non-pvlan path (`scheme != pvlan`). Consider logging (at least debug/warn) why pvlan setup is being skipped (null NIC vs null broadcast URI) so future incidents are diagnosable.
   ```suggestion
           if (nic == null) {
               logger.debug("Skipping PVLAN setup on host {} because NIC profile is null", hostId);
               return false;
           }
   
           if (nic.getBroadCastUri() == null) {
               logger.debug("Skipping PVLAN setup on host {} for NIC with MAC {} because broadcast URI is null", hostId, nic.getMacAddress());
               return false;
           }
   
           String scheme = nic.getBroadCastUri().getScheme();
           if (!"pvlan".equals(scheme)) {
               logger.debug("Skipping PVLAN setup on host {} for NIC with MAC {} because broadcast URI scheme is '{}'", hostId, nic.getMacAddress(), scheme);
   ```



##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -5415,9 +5420,14 @@ public boolean setupVmForPvlan(boolean add, Long hostId, NicProfile nic) {
         }
         Network network = _networkDao.findById(nic.getNetworkId());
         Host host = _hostDao.findById(hostId);
+        if (host == null) {
+            logger.warn("Host with id {} doesn't exist", hostId);
+            return false;
+        }

Review Comment:
   The network lookup is performed even when `hostId` is invalid and the method returns early. Consider fetching/validating `host` before calling `_networkDao.findById(...)` to avoid unnecessary DAO work in this error path.
   ```suggestion
           Host host = _hostDao.findById(hostId);
           if (host == null) {
               logger.warn("Host with id {} doesn't exist", hostId);
               return false;
           }
           Network network = _networkDao.findById(nic.getNetworkId());
   ```



##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -5415,9 +5420,14 @@ public boolean setupVmForPvlan(boolean add, Long hostId, NicProfile nic) {
         }
         Network network = _networkDao.findById(nic.getNetworkId());
         Host host = _hostDao.findById(hostId);
+        if (host == null) {
+            logger.warn("Host with id {} doesn't exist", hostId);

Review Comment:
   Consider changing the log message to avoid the contraction \"doesn't\" (e.g., \"does not exist\") for consistency and formality in logs.
   ```suggestion
               logger.warn("Host with id {} does not exist", hostId);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix NPE during VM setup for pvlan [cloudstack]

Posted by "davift (via GitHub)" <gi...@apache.org>.
davift commented on PR #12781:
URL: https://github.com/apache/cloudstack/pull/12781#issuecomment-4101804510

   > > Dear @sureshanaparti , what is the issue number that this PR relates to?
   > 
   > @daviftorres , I don’t think there is an issue number linked as @sureshanaparti immediately started fixing an issue he saw. We can link any candidate issues retrospectively though.
   
   Dear @DaanHoogland,
   
   Panic shared this PR with me as a reference to a known issue we are experiencing in our production environment. However, the PR description does not clearly explain what problem it is resolving.
   
   That’s why I opened the issue, to get more clarity and additional context.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix NPE during VM setup for pvlan [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12781:
URL: https://github.com/apache/cloudstack/pull/12781#issuecomment-4044822000

   @sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix NPE during VM setup for pvlan [cloudstack]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #12781:
URL: https://github.com/apache/cloudstack/pull/12781#issuecomment-4030377755

   ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/12781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 3.70%. Comparing base ([`7aa0558`](https://app.codecov.io/gh/apache/cloudstack/commit/7aa0558c5b9127ef1633e151baf60ce7172ceaff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9b7a8ab`](https://app.codecov.io/gh/apache/cloudstack/commit/9b7a8ab888f5d4177e0096ab5eecf1d7c466774f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   > :exclamation:  There is a different number of reports uploaded between BASE (7aa0558) and HEAD (9b7a8ab). Click for more details.
   > 
   > <details><summary>HEAD has 1 upload less than BASE</summary>
   >
   >| Flag | BASE (7aa0558) | HEAD (9b7a8ab) |
   >|------|------|------|
   >|unittests|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##               4.22   #12781       +/-   ##
   =============================================
   - Coverage     17.61%    3.70%   -13.91%     
   =============================================
     Files          5917      448     -5469     
     Lines        531402    38019   -493383     
     Branches      64971     7035    -57936     
   =============================================
   - Hits          93596     1409    -92187     
   + Misses       427252    36423   -390829     
   + Partials      10554      187    -10367     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/12781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/12781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.70% <ø> (ø)` | |
   | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/12781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/12781?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix NPE during VM setup for pvlan [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12781:
URL: https://github.com/apache/cloudstack/pull/12781#issuecomment-4051038863

   <b>[SF] Trillian test result (tid-15621)</b>
   Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
   Total time taken: 51959 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12781-t15621-kvm-ol8.zip
   Smoke tests completed. 146 look OK, 3 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestListIdsParams>:teardown | `Error` | 1.15 | test_list_ids_parameter.py
   test_01_snapshot_root_disk | `Error` | 3.73 | test_snapshots.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 47.64 | test_snapshots.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 47.65 | test_snapshots.py
   ContextSuite context=TestSnapshotStandaloneBackup>:teardown | `Error` | 27.61 | test_snapshots.py
   test_01_snapshot_usage | `Error` | 36.00 | test_usage.py
   test_01_vpn_usage | `Error` | 1.09 | test_usage.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix NPE during VM setup for pvlan [cloudstack]

Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #12781:
URL: https://github.com/apache/cloudstack/pull/12781#issuecomment-4037619075

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix NPE during VM setup for pvlan [cloudstack]

Posted by "davift (via GitHub)" <gi...@apache.org>.
davift commented on PR #12781:
URL: https://github.com/apache/cloudstack/pull/12781#issuecomment-4130901671

   > > Panic shared this PR with me as a reference to a known issue we are experiencing in our production environment. However, the PR description does not clearly explain what problem it is resolving.
   > > That’s why I opened the issue, to get more clarity and additional context.
   > 
   > Which issue # @davift ?
   
   Andrija Panic helped me on a ticket through ShapeBlue and he pointed that this PR fixed the issue we have encountered. But I cannot make my own assessment of the case based on the PR description.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix NPE during VM setup for pvlan [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #12781:
URL: https://github.com/apache/cloudstack/pull/12781#issuecomment-4090996913

   > Dear @sureshanaparti , what is the issue number that this PR relates to?
   
   @daviftorres , I don’t think there is an issue number linked as @sureshanaparti immediately started fixing an issue he saw. We can link any candidate issues retrospectively though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix NPE during VM setup for pvlan [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12781:
URL: https://github.com/apache/cloudstack/pull/12781#issuecomment-4037621461

   @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix NPE during VM setup for pvlan [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12781:
URL: https://github.com/apache/cloudstack/pull/12781#issuecomment-4038098220

   Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 17091


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix NPE during VM setup for pvlan [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache merged PR #12781:
URL: https://github.com/apache/cloudstack/pull/12781


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix NPE during VM setup for pvlan [cloudstack]

Posted by "daviftorres (via GitHub)" <gi...@apache.org>.
daviftorres commented on PR #12781:
URL: https://github.com/apache/cloudstack/pull/12781#issuecomment-4084964031

   Dear @sureshanaparti , what is the issue number that this PR relates to?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix NPE during VM setup for pvlan [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #12781:
URL: https://github.com/apache/cloudstack/pull/12781#issuecomment-4127797375

   > Panic shared this PR with me as a reference to a known issue we are experiencing in our production environment. However, the PR description does not clearly explain what problem it is resolving.
   > 
   > That’s why I opened the issue, to get more clarity and additional context.
   
   Which issue # @davift ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix NPE during VM setup for pvlan [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #12781:
URL: https://github.com/apache/cloudstack/pull/12781#issuecomment-4153247337

   > > > Panic shared this PR with me as a reference to a known issue we are experiencing in our production environment. However, the PR description does not clearly explain what problem it is resolving.
   > > > That’s why I opened the issue, to get more clarity and additional context.
   > > 
   > > 
   > > Which issue # @davift ?
   > 
   > Andrija Panic helped me on a ticket through ShapeBlue and he pointed that this PR fixed the issue we have encountered. But I cannot make my own assessment of the case based on the PR description.
   
   aha, Shapeblue does not publish customer issues (as I imagine others do not either). So for all sakes of argument there is no issue. They do often anonymise and create shadow issues for those and then we can refer them here, but we cannot link to “non-existent” issues.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix NPE during VM setup for pvlan [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12781:
URL: https://github.com/apache/cloudstack/pull/12781#issuecomment-4030244732

   @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix NPE during VM setup for pvlan [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12781:
URL: https://github.com/apache/cloudstack/pull/12781#issuecomment-4030752143

   Packaging result [SF]: ✖️ el8 ✖️ el9  ✔️ debian ✖️ suse15. SL-JID 17068


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix NPE during VM setup for pvlan [cloudstack]

Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #12781:
URL: https://github.com/apache/cloudstack/pull/12781#issuecomment-4044816308

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org