[Impala-ASF-CR] IMPALA-9124: ImpalaServer and ClientRequestState refactoring

["Lars Volker (Code Review)" <ge...@cloudera.org>]

Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/14755 )

Change subject: IMPALA-9124: ImpalaServer and ClientRequestState refactoring
......................................................................


Patch Set 5:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/14755/5/be/src/service/client-request-state.h
File be/src/service/client-request-state.h:

http://gerrit.cloudera.org:8080/#/c/14755/5/be/src/service/client-request-state.h@76
PS5, Line 76: exec_request
nit: update comment


http://gerrit.cloudera.org:8080/#/c/14755/5/be/src/service/client-request-state.h@192
PS5, Line 192: Load
I think "Load" is slightly misleading here, it suggests that this comes from some kind of store? How about InitExecRequest()?


http://gerrit.cloudera.org:8080/#/c/14755/5/be/src/service/client-request-state.h@231
PS5, Line 231:   const TExecRequest& exec_request() const {
This could DCHECK that the exec_request_ has been initialized. Then you could revert to calling it in the .cc file.


http://gerrit.cloudera.org:8080/#/c/14755/5/be/src/service/client-request-state.h@471
PS5, Line 471:   /// is loaded in LoadExecRequest(TQueryCtx).
Mention that it must not be used before initializing it?


http://gerrit.cloudera.org:8080/#/c/14755/5/be/src/service/impala-server.h
File be/src/service/impala-server.h:

http://gerrit.cloudera.org:8080/#/c/14755/5/be/src/service/impala-server.h@1091
PS5, Line 1091: shared_ptr
This is now confusing.



-- 
To view, visit http://gerrit.cloudera.org:8080/14755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib92c932a69802225af3fd9bf15f85c85317acaca
Gerrit-Change-Number: 14755
Gerrit-PatchSet: 5
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Dec 2019 00:35:12 +0000
Gerrit-HasComments: Yes