[GitHub] [spark] xuanyuanking commented on a change in pull request #30545: [SPARK-33596][SS] NPE when there is no watermark metrics

[GitBox <gi...@apache.org>]

xuanyuanking commented on a change in pull request #30545:
URL: https://github.com/apache/spark/pull/30545#discussion_r532420800



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/ui/StreamingQueryStatisticsPage.scala
##########
@@ -150,10 +150,10 @@ private[ui] class StreamingQueryStatisticsPage(parent: StreamingQueryTab)
     if (query.lastProgress.eventTime.containsKey("watermark")) {
       val watermarkData = query.recentProgress.flatMap { p =>
         val batchTimestamp = parseProgressTimestamp(p.timestamp)
-        val watermarkValue = parseProgressTimestamp(p.eventTime.get("watermark"))

Review comment:
       Could you give more details about the NPE? We already check the `watermark` key in lastProgress.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org