[GitHub] [incubator-kie-kogito-examples] fjtirado commented on a diff in pull request #1813: KOGITO-9807: Create SW example with data-index persistence addon

["fjtirado (via GitHub)" <gi...@apache.org>]

fjtirado commented on code in PR #1813:
URL: https://github.com/apache/incubator-kie-kogito-examples/pull/1813#discussion_r1337524328


##########
serverless-workflow-examples/serverless-workflow-data-index-persistence-addon-quarkus/src/main/resources/callback.sw.json:
##########
@@ -0,0 +1,70 @@
+{
+  "id": "callback",
+  "version": "1.0",
+  "name": "Workflow Callback example",
+  "description": "An example of how to use callback state",
+  "errors": [
+    {
+      "name": "execution error",
+      "code": "java.util.concurrent.CompletionException"
+    }
+  ],
+  "start": "waitForEvent",
+  "events": [
+    {
+      "name": "resumeEvent",
+      "source": "",
+      "type": "resume"
+    },
+    {
+      "name": "waitEvent",
+      "source": "",
+      "type": "wait"
+    }
+  ],
+  "functions": [

Review Comment:
   I would remove that service call. 
   Using a service call to just print the service id is discouraged. 
   We should  use sysout together with $WORKFLOW.instanceId instead



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org