[jira] [Commented] (FLINK-7032) Intellij is constantly changing language level of sub projects back to 1.6

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067061#comment-16067061 ] 

ASF GitHub Bot commented on FLINK-7032:
---------------------------------------

GitHub user pnowojski opened a pull request:

    https://github.com/apache/flink/pull/4213

    [FLINK-7032] Overwrite inherited properties from parent pom

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pnowojski/flink java17

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4213.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4213
    
----
commit 257fc92a98dc1d28014bccc9bb3171e9a38062ab
Author: Piotr Nowojski <pi...@gmail.com>
Date:   2017-06-28T18:30:08Z

    [FLINK-7032] Overwrite inherited properties from parent pom
    
    Default values for compiler version are 1.6 and were causing Intellij to
    constantly switch language level to 1.6, which in turn was causing
    compilation errors. It worked fine for compiling from console using
    maven, because those values are separetly set in maven-compiler-plugin
    configuration.

----


> Intellij is constantly changing language level of sub projects back to 1.6 
> ---------------------------------------------------------------------------
>
>                 Key: FLINK-7032
>                 URL: https://issues.apache.org/jira/browse/FLINK-7032
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Piotr Nowojski
>            Assignee: Piotr Nowojski
>
> Every time I do maven reimport projects, Intellij is switching back to 1.6 language level. I tracked down this issue to misconfiguration in our pom.xml file. It correctly configure maven-compiler-plugin:
> {code:xml}
> 			<plugin>
> 				<!-- just define the Java version to be used for compiling and plugins -->
> 				<groupId>org.apache.maven.plugins</groupId>
> 				<artifactId>maven-compiler-plugin</artifactId>
> 				<version>3.1</version><!--$NO-MVN-MAN-VER$-->
> 				<configuration>
> 					<source>${java.version}</source>
> 					<target>${java.version}</target>
> 					<!-- The output of Xlint is not shown by default, but we activate it for the QA bot
> 					to be able to get more warnings -->
> 					<compilerArgument>-Xlint:all</compilerArgument>
> 				</configuration>
> 			</plugin>
> {code}
> where ${java.version} is set to 1.7 in the properties, but it forgets to overwrite the following properties from apache-18.pom:
> {code:xml}
>   <properties>
>     <maven.compiler.source>1.6</maven.compiler.source>
>     <maven.compiler.target>1.6</maven.compiler.target>
>   </properties>
> {code}
> It seems like compiling from console using maven ignores those values, but they are confusing Intellij.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)