You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/01/21 20:33:20 UTC
[GitHub] [geode] nonbinaryprogrammer opened a new pull request #5942: GEODE-8863: test HSETNX concurrency
nonbinaryprogrammer opened a new pull request #5942:
URL: https://github.com/apache/geode/pull/5942
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on pull request #5942: GEODE-8863: test HSETNX concurrency
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on pull request #5942:
URL: https://github.com/apache/geode/pull/5942#issuecomment-765738706
if desired to clearly see the diff before merging this, you could squash then rebase to latest develop
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbey37 commented on a change in pull request #5942: GEODE-8863: test HSETNX concurrency
Posted by GitBox <gi...@apache.org>.
sabbey37 commented on a change in pull request #5942:
URL: https://github.com/apache/geode/pull/5942#discussion_r562728647
##########
File path: geode-redis/src/distributedTest/java/org/apache/geode/redis/internal/executor/hash/HSetNXDunitTest.java
##########
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
+ * agreements. See the NOTICE file distributed with this work for additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.redis.internal.executor.hash;
+
+import static org.apache.geode.distributed.ConfigurationProperties.REDIS_PORT;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.Future;
+
+import io.lettuce.core.ClientOptions;
+import io.lettuce.core.RedisClient;
+import io.lettuce.core.api.StatefulRedisConnection;
+import io.lettuce.core.api.sync.RedisCommands;
+import io.lettuce.core.resource.ClientResources;
+import org.junit.AfterClass;
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+
+import org.apache.geode.internal.AvailablePortHelper;
+import org.apache.geode.redis.session.springRedisTestApplication.config.DUnitSocketAddressResolver;
+import org.apache.geode.test.dunit.rules.MemberVM;
+import org.apache.geode.test.dunit.rules.RedisClusterStartupRule;
+import org.apache.geode.test.junit.rules.ExecutorServiceRule;
+
+public class HSetNXDunitTest {
+ @ClassRule
+ public static RedisClusterStartupRule cluster = new RedisClusterStartupRule();
+
+ @ClassRule
+ public static ExecutorServiceRule executor = new ExecutorServiceRule();
+
+ private static final int HASH_SIZE = 50000;
+ private static MemberVM locator;
+ private static MemberVM server1;
+ private static MemberVM server2;
+ private static int[] redisPorts;
+ private static RedisCommands<String, String> lettuce;
+ private static StatefulRedisConnection<String, String> connection;
+ private static ClientResources resources;
+
+ @BeforeClass
+ public static void classSetup() {
+ redisPorts = AvailablePortHelper.getRandomAvailableTCPPorts(3);
+
+ String redisPort1 = "" + redisPorts[0];
+ String redisPort2 = "" + redisPorts[1];
+
+ locator = cluster.startLocatorVM(0);
+
+ server1 = startRedisVM(1, redisPorts[0]);
+ server2 = startRedisVM(2, redisPorts[1]);
+
+ DUnitSocketAddressResolver dnsResolver =
+ new DUnitSocketAddressResolver(new String[] {redisPort2, redisPort1});
+
+ resources = ClientResources.builder()
+ .socketAddressResolver(dnsResolver)
+ .build();
+
+ RedisClient redisClient = RedisClient.create(resources, "redis://localhost");
+ redisClient.setOptions(ClientOptions.builder()
+ .autoReconnect(true)
+ .build());
+ connection = redisClient.connect();
+ lettuce = connection.sync();
+ }
+
+ @Before
+ public void testSetup() {
+ lettuce.flushall();
+ }
+
+ @AfterClass
+ public static void tearDown() throws Exception {
+ resources.shutdown().get();
+ connection.close();
+ server1.stop();
+ server2.stop();
+ }
+
+ @Test
+ public void testHSETNXReturnsOneWhenKeyDoesNotExistAndZeroWhenItDoes()
+ throws ExecutionException, InterruptedException {
+ String key = "HSETNX";
+
+ for (int i = 0; i < 1000; i++) {
+ int local_i = i;
+
+ Future<Boolean> server_1_counter = executor.submit(
+ () -> lettuce.hsetnx(key, "field" + local_i, "value" + local_i));
+ Future<Boolean> server_2_counter = executor.submit(
+ () -> lettuce.hsetnx(key, "field" + local_i, "value" + local_i));
+
+ assertThat(server_1_counter.get() ^ server_2_counter.get()).isTrue();
+ }
+ }
Review comment:
This is really cool!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] nonbinaryprogrammer merged pull request #5942: GEODE-8863: test HSETNX concurrency
Posted by GitBox <gi...@apache.org>.
nonbinaryprogrammer merged pull request #5942:
URL: https://github.com/apache/geode/pull/5942
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org