You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/07 14:24:39 UTC
[GitHub] [doris] zbtzbtzbt opened a new pull request, #15705: [refactor] refactor Segment writer
zbtzbtzbt opened a new pull request, #15705:
URL: https://github.com/apache/doris/pull/15705
# Proposed changes
- seperate segment write logic of data area and index area
- more concise clear
- other small change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15705: [refactor] refactor method finalize_columns of segment writer
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15705:
URL: https://github.com/apache/doris/pull/15705#issuecomment-1376635122
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zbtzbtzbt commented on pull request #15705: [refactor] refactor segment writer
Posted by GitBox <gi...@apache.org>.
zbtzbtzbt commented on PR #15705:
URL: https://github.com/apache/doris/pull/15705#issuecomment-1374999397
@yixiutt @dataroaring
I refactor some of your code.
cc, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15705: [refactor] refactor method finalize_columns of segment writer
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15705:
URL: https://github.com/apache/doris/pull/15705#issuecomment-1381654984
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15705: [refactor] refactor Segment writer
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15705:
URL: https://github.com/apache/doris/pull/15705#issuecomment-1374498861
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zbtzbtzbt commented on pull request #15705: [refactor] refactor method finalize_columns of segment writer
Posted by GitBox <gi...@apache.org>.
zbtzbtzbt commented on PR #15705:
URL: https://github.com/apache/doris/pull/15705#issuecomment-1375584281
> pls update the title, `refactor segment writer` sounds like a big change... I think the title should be `refactor method finalize_columns of segment writer`
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15705: [refactor] refactor method finalize_columns of segment writer
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15705:
URL: https://github.com/apache/doris/pull/15705#issuecomment-1378516090
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15705: [refactor] refactor method finalize_columns of segment writer
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15705:
URL: https://github.com/apache/doris/pull/15705#issuecomment-1377457196
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yixiutt commented on pull request #15705: [refactor] refactor method finalize_columns of segment writer
Posted by GitBox <gi...@apache.org>.
yixiutt commented on PR #15705:
URL: https://github.com/apache/doris/pull/15705#issuecomment-1376890109
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15705: [refactor] refactor method finalize_columns of segment writer
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15705:
URL: https://github.com/apache/doris/pull/15705#issuecomment-1377049476
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zbtzbtzbt commented on pull request #15705: [refactor] refactor method finalize_columns of segment writer
Posted by GitBox <gi...@apache.org>.
zbtzbtzbt commented on PR #15705:
URL: https://github.com/apache/doris/pull/15705#issuecomment-1375584049
>
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15705: [refactor] refactor Segment writer
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15705:
URL: https://github.com/apache/doris/pull/15705#issuecomment-1374503799
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.14 seconds
load time: 476 seconds
storage size: 17121492959 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230107144625_clickbench_pr_75425.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring merged pull request #15705: [refactor] refactor method finalize_columns of segment writer
Posted by GitBox <gi...@apache.org>.
dataroaring merged PR #15705:
URL: https://github.com/apache/doris/pull/15705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org