You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Lee-W (via GitHub)" <gi...@apache.org> on 2023/09/07 07:12:20 UTC
[GitHub] [airflow] Lee-W commented on pull request #34113: Refactor: Consolidate 'import textwrap'
Lee-W commented on PR #34113:
URL: https://github.com/apache/airflow/pull/34113#issuecomment-1709599439
> > I'm a bit curious about why we want to do it this way. Also, would it make sense if we document these changes somewhere in the contribution document so that newcomers know what to follow?
>
> Grepping and counting for imports of textwrap shows:
>
> ```
> 11 from textwrap import dedent
> 3 from textwrap import wrap
> 37 import textwrap
> ```
>
> the majority imports `textwrap` directly, so I am suggesting to do it so everywhere.
Yep, sounds reasonable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org