You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Michael Luckey (JIRA)" <ji...@apache.org> on 2019/05/01 16:53:00 UTC

[jira] [Created] (BEAM-7197) ParDoLifecycleTest: exeption throwing tests broken

Michael Luckey created BEAM-7197:
------------------------------------

             Summary: ParDoLifecycleTest: exeption throwing tests broken
                 Key: BEAM-7197
                 URL: https://issues.apache.org/jira/browse/BEAM-7197
             Project: Beam
          Issue Type: Bug
          Components: sdk-java-core
            Reporter: Michael Luckey
            Assignee: Michael Luckey


ParDoLifecycleTest implements tests to assert that DoFn are tore down after another lifecycle method throw an exception.
 
The implementation uses a static AtomicBoolean for assertions [1]. Unfortunately, this is never reset which results in that boolean being true after the first test which happens to correctly call teardown on exception. Failures for tests executed after are essentially hidden.

This can be seen e.g. by
{code:bash}
./gradlew -p runners/spark/ validatesRunnerBatch --tests org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInStartBundle 
{code}

[1] https://github.com/apache/beam/blob/master/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoLifecycleTest.java#L407-L412




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)