You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by al...@apache.org on 2020/04/21 22:01:54 UTC

[incubator-datasketches-characterization] branch HLL_Java_Cpp_Test updated: cleanup

This is an automated email from the ASF dual-hosted git repository.

alsay pushed a commit to branch HLL_Java_Cpp_Test
in repository https://gitbox.apache.org/repos/asf/incubator-datasketches-characterization.git


The following commit(s) were added to refs/heads/HLL_Java_Cpp_Test by this push:
     new 5183ccd  cleanup
5183ccd is described below

commit 5183ccd0003e06b78d362a2fae24ffdd85c57cd2
Author: AlexanderSaydakov <Al...@users.noreply.github.com>
AuthorDate: Tue Apr 21 15:01:19 2020 -0700

    cleanup
---
 cpp/src/hll_cross_language_profile.cpp | 21 ++-------------------
 cpp/src/hll_cross_language_profile.hpp |  1 -
 2 files changed, 2 insertions(+), 20 deletions(-)

diff --git a/cpp/src/hll_cross_language_profile.cpp b/cpp/src/hll_cross_language_profile.cpp
index e9f83a4..9c2d88d 100644
--- a/cpp/src/hll_cross_language_profile.cpp
+++ b/cpp/src/hll_cross_language_profile.cpp
@@ -27,22 +27,6 @@
 namespace datasketches {
 
 void hll_cross_language_profile::run() {
-  /*
-  for (int t = 0; t < 3; t++) {
-    std::string t_str = std::to_string(t * 2 + 4);
-    for (int lg_k = BASE_LG_K; lg_k <= BASE_LG_K + 1; lg_k++) {
-      for (int m = 0; m < 4; m++) {
-        std::string mode = MODE_ARR[m];
-        std::string fname = "Hll" + t_str + "K" + std::to_string(lg_k) + mode + ".bin";
-        std::cout << "reading " << fname << std::endl;
-        std::ifstream is;
-        is.exceptions(std::ios::failbit | std::ios::badbit);
-        is.open(DATA_PATH + "/" + fname, std::ios::binary);
-        hll_sketch sketch = hll_sketch::deserialize(is);
-      }
-    }
-  }
-  */
   for (int i = 0; i < 4; i++) {
     const int lg_k_seq = LG_K_SEQ_ARR[i];
     const int u_lg_k = BASE_LG_K + ((lg_k_seq & 4) > 0 ? 1 : 0);
@@ -92,6 +76,8 @@ void hll_cross_language_profile::run() {
             std::cerr << "Expected bytes:" << std::endl << std::hex;
             for (auto byte: expected_bytes) std::cerr << std::setw(2) << std::setfill('0') << (int) byte;
             std::cerr  << std::endl;
+            std::cerr << "Actual unon:" << std::endl;
+            test_union.to_string(std::cout);
             throw std::runtime_error(u_fname + " mismatch");
           }
         }
@@ -100,7 +86,4 @@ void hll_cross_language_profile::run() {
   }
 }
 
-void hll_cross_language_profile::build_file_map_and_file_list() {
-}
-
 }
diff --git a/cpp/src/hll_cross_language_profile.hpp b/cpp/src/hll_cross_language_profile.hpp
index 0171c83..5fab2c6 100644
--- a/cpp/src/hll_cross_language_profile.hpp
+++ b/cpp/src/hll_cross_language_profile.hpp
@@ -27,7 +27,6 @@ namespace datasketches {
 class hll_cross_language_profile: public job_profile {
 public:
   void run();
-  void build_file_map_and_file_list();
 private:
   const std::string DATA_PATH = "../src/main/resources/hll/data";
   const int BASE_LG_K = 8;


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org