You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Shai Erera <se...@gmail.com> on 2015/04/18 09:07:16 UTC
Change line length setting in eclipse to 120 chars
Hi
Our dev-tools/eclipse configure the project to break lines on 80
characters. Are there objections to change it to 120?
Shai
Re: Change line length setting in eclipse to 120 chars
Posted by Shai Erera <se...@gmail.com>.
Opene LUCENE-6441 with a patch.
Shai
On Mon, Apr 20, 2015 at 4:23 PM, Mark Miller <ma...@gmail.com> wrote:
> +1. I have to constantly unwrap lines after formating. Better to make it
> the other way.
>
> - Mark
>
> On Mon, Apr 20, 2015 at 8:58 AM Uwe Schindler <uw...@thetaphi.de> wrote:
>
>> +1
>>
>> Please fix the Eclipse config to not force any breaks.
>>
>> Uwe
>>
>> Am 20. April 2015 14:13:15 MESZ, schrieb Toke Eskildsen <
>> te@statsbiblioteket.dk>:
>>
>>> On Sat, 2015-04-18 at 10:07 +0300, Shai Erera wrote:
>>>
>>> Our dev-tools/eclipse configure the project to break lines on 80
>>>> characters. Are there objections to change it to 120?
>>>>
>>>
>>> Line length was discussed back in 2013 (search for "Line length in
>>> Lucene/Solr code") and AFAIR the conclusion was not to have a hard max,
>>> but to aim for <= 120 characters/line.
>>>
>>> (it might be worth stating this on
>>> https://wiki.apache.org/solr/HowToContribute)
>>>
>>>>
>>>>
>>>> Shai
>>>>
>>>>
>>>
>>>
>>>
>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail:dev-help@lucene.apache.org
>>>
>>>
>> --
>> Uwe Schindler
>> H.-H.-Meier-Allee 63, 28213 Bremen
>> http://www.thetaphi.de
>>
>
Re: Change line length setting in eclipse to 120 chars
Posted by Mark Miller <ma...@gmail.com>.
+1. I have to constantly unwrap lines after formating. Better to make it
the other way.
- Mark
On Mon, Apr 20, 2015 at 8:58 AM Uwe Schindler <uw...@thetaphi.de> wrote:
> +1
>
> Please fix the Eclipse config to not force any breaks.
>
> Uwe
>
> Am 20. April 2015 14:13:15 MESZ, schrieb Toke Eskildsen <
> te@statsbiblioteket.dk>:
>
>> On Sat, 2015-04-18 at 10:07 +0300, Shai Erera wrote:
>>
>> Our dev-tools/eclipse configure the project to break lines on 80
>>> characters. Are there objections to change it to 120?
>>>
>>
>> Line length was discussed back in 2013 (search for "Line length in
>> Lucene/Solr code") and AFAIR the conclusion was not to have a hard max,
>> but to aim for <= 120 characters/line.
>>
>> (it might be worth stating this on
>> https://wiki.apache.org/solr/HowToContribute)
>>
>>>
>>>
>>> Shai
>>>
>>>
>>
>>
>>
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail:dev-help@lucene.apache.org
>>
>>
> --
> Uwe Schindler
> H.-H.-Meier-Allee 63, 28213 Bremen
> http://www.thetaphi.de
>
Re: Change line length setting in eclipse to 120 chars
Posted by Uwe Schindler <uw...@thetaphi.de>.
+1
Please fix the Eclipse config to not force any breaks.
Uwe
Am 20. April 2015 14:13:15 MESZ, schrieb Toke Eskildsen <te...@statsbiblioteket.dk>:
>On Sat, 2015-04-18 at 10:07 +0300, Shai Erera wrote:
>
>> Our dev-tools/eclipse configure the project to break lines on 80
>> characters. Are there objections to change it to 120?
>
>Line length was discussed back in 2013 (search for "Line length in
>Lucene/Solr code") and AFAIR the conclusion was not to have a hard max,
>but to aim for <= 120 characters/line.
>
>(it might be worth stating this on
>https://wiki.apache.org/solr/HowToContribute)
>>
>>
>> Shai
>>
>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>For additional commands, e-mail: dev-help@lucene.apache.org
--
Uwe Schindler
H.-H.-Meier-Allee 63, 28213 Bremen
http://www.thetaphi.de
Re: Change line length setting in eclipse to 120 chars
Posted by Shai Erera <se...@gmail.com>.
The problem is that our scripts configure to break on 80 characters, which
is annoying when I format lines, because I then need to rewrap them if I
want. I'll open an issue with a change, people can object/support there.
Thanks Toke!
Shai
On Mon, Apr 20, 2015 at 3:13 PM, Toke Eskildsen <te...@statsbiblioteket.dk>
wrote:
> On Sat, 2015-04-18 at 10:07 +0300, Shai Erera wrote:
>
> > Our dev-tools/eclipse configure the project to break lines on 80
> > characters. Are there objections to change it to 120?
>
> Line length was discussed back in 2013 (search for "Line length in
> Lucene/Solr code") and AFAIR the conclusion was not to have a hard max,
> but to aim for <= 120 characters/line.
>
> (it might be worth stating this on
> https://wiki.apache.org/solr/HowToContribute)
> >
> >
> > Shai
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
Re: Change line length setting in eclipse to 120 chars
Posted by Toke Eskildsen <te...@statsbiblioteket.dk>.
On Sat, 2015-04-18 at 10:07 +0300, Shai Erera wrote:
> Our dev-tools/eclipse configure the project to break lines on 80
> characters. Are there objections to change it to 120?
Line length was discussed back in 2013 (search for "Line length in
Lucene/Solr code") and AFAIR the conclusion was not to have a hard max,
but to aim for <= 120 characters/line.
(it might be worth stating this on
https://wiki.apache.org/solr/HowToContribute)
>
>
> Shai
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org