You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Krisztian Kasa <kk...@hortonworks.com> on 2020/02/27 12:54:35 UTC

Review Request 72168: HIVE-22929

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72168/
-----------------------------------------------------------

Review request for hive, Gopal V and Jesús Camacho Rodríguez.


Bugs: HIVE-22929
    https://issues.apache.org/jira/browse/HIVE-22929


Repository: hive-git


Description
-------

Performance: quoted identifier parsing uses throwaway Regex via String.replaceAll()


Diffs
-----

  parser/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 0296a3d74e 
  ql/src/java/org/apache/hadoop/hive/ql/ddl/misc/conf/ShowConfOperation.java 88ec1ea9d2 
  ql/src/java/org/apache/hadoop/hive/ql/ddl/table/column/show/ShowColumnsOperation.java ee98f605fc 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java e9966e6364 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HivePreWarmProcessor.java b6c0d7f3d8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java d3fe190e4e 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastStringToDateWithFormat.java b50ed0e70c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastStringToTimestampWithFormat.java 9361e77de8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FilterStringColRegExpStringScalar.java 94d37f72ec 
  ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java 08aeeb2acd 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java 26c7a606bf 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/JarUtils.java cde7459170 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java 3dcf876af3 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java 5dbb69d302 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/NullScanTaskDispatcher.java 9b5a099246 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SplitSparkWorkResolver.java 4d0331df8a 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 35f7ec674a 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ReplicationSpec.java 99b09e5ea9 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java fed890f031 
  ql/src/java/org/apache/hadoop/hive/ql/parse/type/ExprNodeDescExprFactory.java 16d354667b 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java 389f5cc86b 


Diff: https://reviews.apache.org/r/72168/diff/1/


Testing
-------

mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=quotedid_basic.q -pl itests/qtest -Pitests


Thanks,

Krisztian Kasa