You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/01/12 14:16:32 UTC

[GitHub] [ignite] NSAmelchev opened a new pull request #8652: IGNITE-13982 Add documentation for new checkpoint, cluster and cache metrics

NSAmelchev opened a new pull request #8652:
URL: https://github.com/apache/ignite/pull/8652


   Thank you for submitting the pull request to the Apache Ignite.
   
   In order to streamline the review of the contribution 
   we ask you to ensure the following steps have been taken:
   
   ### The Contribution Checklist
   - [ ] There is a single JIRA ticket related to the pull request. 
   - [ ] The web-link to the pull request is attached to the JIRA ticket.
   - [ ] The JIRA ticket has the _Patch Available_ state.
   - [ ] The pull request body describes changes that have been made. 
   The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
   - [ ] The pull request title is treated as the final commit message. 
   The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
   - [ ] A reviewer has been mentioned through the JIRA comments 
   (see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers)) 
   - [ ] The pull request has been checked by the Teamcity Bot and 
   the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
   
   ### Notes
   - [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
   - [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
   - [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
   - [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
   
   If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Mmuzaf merged pull request #8652: IGNITE-13982 Add documentation for new checkpoint, cluster and cache metrics

Posted by GitBox <gi...@apache.org>.
Mmuzaf merged pull request #8652:
URL: https://github.com/apache/ignite/pull/8652


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] NSAmelchev commented on a change in pull request #8652: IGNITE-13982 Add documentation for new checkpoint, cluster and cache metrics

Posted by GitBox <gi...@apache.org>.
NSAmelchev commented on a change in pull request #8652:
URL: https://github.com/apache/ignite/pull/8652#discussion_r557070753



##########
File path: docs/_docs/monitoring-metrics/new-metrics.adoc
##########
@@ -320,15 +326,33 @@ Register name: `io.datastorage`
 [cols="2,1,3",opts="header"]
 |===
 |Name |    Type |    Description
+|CheckpointBeforeLockHistogram| histogram |   Histogram of checkpoint action before taken write lock durations in milliseconds.
+|CheckpointFsyncHistogram| histogram |   Histogram of checkpoint fsync durations in milliseconds.
+|CheckpointHistogram| histogram |   Histogram of checkpoint durations in milliseconds.
+|CheckpointListenersExecuteHistogram| histogram |   Histogram of checkpoint execution listeners under write lock durations in milliseconds.
+|CheckpointLockHoldHistogram| histogram |   Histogram of checkpoint lock hold durations in milliseconds.
+|CheckpointLockWaitHistogram| histogram |   Histogram of checkpoint lock wait durations in milliseconds.
+|CheckpointMarkHistogram| histogram |   Histogram of checkpoint mark durations in milliseconds.
+|CheckpointPagesWriteHistogram| histogram |   Histogram of checkpoint pages write durations in milliseconds.
+|CheckpointSplitAndSortPagesHistogram| histogram |   Histogram of splitting and sorting checkpoint pages durations in milliseconds.
 |CheckpointTotalTime| long |   Total duration of checkpoint
+|CheckpointWalRecordFsyncHistogram| histogram |   Histogram of the WAL fsync after logging ChTotalNodeseckpointRecord on begin of checkpoint durations in milliseconds.
+|CheckpointWriteEntryHistogram| histogram |   Histogram of entry buffer writing to file durations in milliseconds.

Review comment:
       @Nikita-tech-writer , It seems that singular is correct. I have fixed docs and metrics descriptions.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8652: IGNITE-13982 Add documentation for new checkpoint, cluster and cache metrics

Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8652:
URL: https://github.com/apache/ignite/pull/8652#discussion_r556481602



##########
File path: docs/_docs/monitoring-metrics/new-metrics.adoc
##########
@@ -78,11 +79,16 @@ Register name: `cache.{cache_name}.{near}`
 |EstimatedRebalancingKeys|long|Number estimated to rebalance keys.
 |GetTime |histogram|   Get time in nanoseconds.
 |GetTimeTotal|long|The total time of cache gets, in nanoseconds.
+|HeapEntriesCount|long|Onheap entries count.
+|IndexRebuildKeyProcessed|long|Number of keys processed during index rebuilding.

Review comment:
       ```suggestion
   |IndexRebuildKeyProcessed|long|Number of keys processed during the index rebuilding.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8652: IGNITE-13982 Add documentation for new checkpoint, cluster and cache metrics

Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8652:
URL: https://github.com/apache/ignite/pull/8652#discussion_r556482560



##########
File path: docs/_docs/monitoring-metrics/new-metrics.adoc
##########
@@ -340,3 +364,21 @@ Register name: `io.datastorage`
 |WalTotalSize|    long  |  Total size in bytes for storage wal files.
 |WalWritingRate|  long  |  Average number of bytes per second written during the last time interval.
 |===
+
+
+== Cluster
+
+Cluster metrics.
+
+Register name: `cluster`
+
+
+[cols="2,1,3",opts="header"]
+|===
+|Name|    Type|    Description
+|ActiveBaselineNodes| integer | Active baseline nodes count.
+|Rebalanced| boolean | True if the cluster has achieved fully rebalanced state. Note that an inactive cluster always has this metric in False regardless of the real partitions state.

Review comment:
       ```suggestion
   |Rebalanced| boolean | True if the cluster has fully achieved rebalanced state. Note that an inactive cluster always has this metric in False regardless of the real partitions state.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] NSAmelchev commented on pull request #8652: IGNITE-13982 Add documentation for new checkpoint, cluster and cache metrics

Posted by GitBox <gi...@apache.org>.
NSAmelchev commented on pull request #8652:
URL: https://github.com/apache/ignite/pull/8652#issuecomment-761760887


   @Nikita-tech-writer I have fixed issues.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8652: IGNITE-13982 Add documentation for new checkpoint, cluster and cache metrics

Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8652:
URL: https://github.com/apache/ignite/pull/8652#discussion_r556546250



##########
File path: docs/_docs/monitoring-metrics/new-metrics.adoc
##########
@@ -320,15 +326,33 @@ Register name: `io.datastorage`
 [cols="2,1,3",opts="header"]
 |===
 |Name |    Type |    Description
+|CheckpointBeforeLockHistogram| histogram |   Histogram of checkpoint action before taken write lock durations in milliseconds.
+|CheckpointFsyncHistogram| histogram |   Histogram of checkpoint fsync durations in milliseconds.
+|CheckpointHistogram| histogram |   Histogram of checkpoint durations in milliseconds.
+|CheckpointListenersExecuteHistogram| histogram |   Histogram of checkpoint execution listeners under write lock durations in milliseconds.
+|CheckpointLockHoldHistogram| histogram |   Histogram of checkpoint lock hold durations in milliseconds.
+|CheckpointLockWaitHistogram| histogram |   Histogram of checkpoint lock wait durations in milliseconds.
+|CheckpointMarkHistogram| histogram |   Histogram of checkpoint mark durations in milliseconds.
+|CheckpointPagesWriteHistogram| histogram |   Histogram of checkpoint pages write durations in milliseconds.
+|CheckpointSplitAndSortPagesHistogram| histogram |   Histogram of splitting and sorting checkpoint pages durations in milliseconds.
 |CheckpointTotalTime| long |   Total duration of checkpoint
+|CheckpointWalRecordFsyncHistogram| histogram |   Histogram of the WAL fsync after logging ChTotalNodeseckpointRecord on begin of checkpoint durations in milliseconds.
+|CheckpointWriteEntryHistogram| histogram |   Histogram of entry buffer writing to file durations in milliseconds.

Review comment:
       Are you sure that it is "duration**s**" (plural), not "duration" (singular) here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] NSAmelchev commented on pull request #8652: IGNITE-13982 Add documentation for new checkpoint, cluster and cache metrics

Posted by GitBox <gi...@apache.org>.
NSAmelchev commented on pull request #8652:
URL: https://github.com/apache/ignite/pull/8652#issuecomment-759442608


   @Nikita-tech-writer , thank you for the review. I have fixed issues.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8652: IGNITE-13982 Add documentation for new checkpoint, cluster and cache metrics

Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8652:
URL: https://github.com/apache/ignite/pull/8652#discussion_r556542479



##########
File path: docs/_docs/monitoring-metrics/new-metrics.adoc
##########
@@ -320,15 +326,33 @@ Register name: `io.datastorage`
 [cols="2,1,3",opts="header"]
 |===
 |Name |    Type |    Description
+|CheckpointBeforeLockHistogram| histogram |   Histogram of checkpoint action before taken write lock durations in milliseconds.
+|CheckpointFsyncHistogram| histogram |   Histogram of checkpoint fsync durations in milliseconds.
+|CheckpointHistogram| histogram |   Histogram of checkpoint durations in milliseconds.
+|CheckpointListenersExecuteHistogram| histogram |   Histogram of checkpoint execution listeners under write lock durations in milliseconds.
+|CheckpointLockHoldHistogram| histogram |   Histogram of checkpoint lock hold durations in milliseconds.
+|CheckpointLockWaitHistogram| histogram |   Histogram of checkpoint lock wait durations in milliseconds.
+|CheckpointMarkHistogram| histogram |   Histogram of checkpoint mark durations in milliseconds.
+|CheckpointPagesWriteHistogram| histogram |   Histogram of checkpoint pages write durations in milliseconds.
+|CheckpointSplitAndSortPagesHistogram| histogram |   Histogram of splitting and sorting checkpoint pages durations in milliseconds.
 |CheckpointTotalTime| long |   Total duration of checkpoint
+|CheckpointWalRecordFsyncHistogram| histogram |   Histogram of the WAL fsync after logging ChTotalNodeseckpointRecord on begin of checkpoint durations in milliseconds.
+|CheckpointWriteEntryHistogram| histogram |   Histogram of entry buffer writing to file durations in milliseconds.
+|LastCheckpointBeforeLockDuration|  long |   Duration of the checkpoint action before taken write lock in milliseconds.
 |LastCheckpointCopiedOnWritePagesNumber|  long |   Number of pages copied to a temporary checkpoint buffer during the last checkpoint.
 |LastCheckpointDataPagesNumber|   long  |  Total number of data pages written during the last checkpoint.
 |LastCheckpointDuration | long  |  Duration of the last checkpoint in milliseconds.
 |LastCheckpointFsyncDuration| long  |  Duration of the sync phase of the last checkpoint in milliseconds.
+|LastCheckpointListenersExecuteDuration|  long|    Duration of the checkpoint execution listeners under write lock in milliseconds.
+|LastCheckpointLockHoldDuration|  long|    Duration of the checkpoint lock hold in milliseconds.
 |LastCheckpointLockWaitDuration|  long|    Duration of the checkpoint lock wait in milliseconds.
-|LastCheckpointMarkDuration | long  |  Duration of the checkpoint lock wait in milliseconds.
+|LastCheckpointMarkDuration | long  |  Duration of the checkpoint mark in milliseconds.
 |LastCheckpointPagesWriteDuration|    long|    Duration of the checkpoint pages write in milliseconds.
 |LastCheckpointTotalPagesNumber|  long|    Total number of pages written during the last checkpoint.
+|LastCheckpointSplitAndSortPagesDuration|  long|    Duration of splitting and sorting checkpoint pages of the last checkpoint in milliseconds.
+|LastCheckpointStart|  long|    Start timestamp of the last checkpoint.
+|LastCheckpointWalRecordFsyncDuration|  long|    Duration of the WAL fsync after logging CheckpointRecord on begin of the last checkpoint in milliseconds.

Review comment:
       or "...at the beginning of the last checkpoint in milliseconds."




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8652: IGNITE-13982 Add documentation for new checkpoint, cluster and cache metrics

Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8652:
URL: https://github.com/apache/ignite/pull/8652#discussion_r556484556



##########
File path: docs/_docs/monitoring-metrics/new-metrics.adoc
##########
@@ -320,15 +326,33 @@ Register name: `io.datastorage`
 [cols="2,1,3",opts="header"]
 |===
 |Name |    Type |    Description
+|CheckpointBeforeLockHistogram| histogram |   Histogram of checkpoint action before taken write lock durations in milliseconds.
+|CheckpointFsyncHistogram| histogram |   Histogram of checkpoint fsync durations in milliseconds.
+|CheckpointHistogram| histogram |   Histogram of checkpoint durations in milliseconds.
+|CheckpointListenersExecuteHistogram| histogram |   Histogram of checkpoint execution listeners under write lock durations in milliseconds.
+|CheckpointLockHoldHistogram| histogram |   Histogram of checkpoint lock hold durations in milliseconds.
+|CheckpointLockWaitHistogram| histogram |   Histogram of checkpoint lock wait durations in milliseconds.
+|CheckpointMarkHistogram| histogram |   Histogram of checkpoint mark durations in milliseconds.
+|CheckpointPagesWriteHistogram| histogram |   Histogram of checkpoint pages write durations in milliseconds.
+|CheckpointSplitAndSortPagesHistogram| histogram |   Histogram of splitting and sorting checkpoint pages durations in milliseconds.
 |CheckpointTotalTime| long |   Total duration of checkpoint
+|CheckpointWalRecordFsyncHistogram| histogram |   Histogram of the WAL fsync after logging ChTotalNodeseckpointRecord on begin of checkpoint durations in milliseconds.
+|CheckpointWriteEntryHistogram| histogram |   Histogram of entry buffer writing to file durations in milliseconds.
+|LastCheckpointBeforeLockDuration|  long |   Duration of the checkpoint action before taken write lock in milliseconds.
 |LastCheckpointCopiedOnWritePagesNumber|  long |   Number of pages copied to a temporary checkpoint buffer during the last checkpoint.
 |LastCheckpointDataPagesNumber|   long  |  Total number of data pages written during the last checkpoint.
 |LastCheckpointDuration | long  |  Duration of the last checkpoint in milliseconds.
 |LastCheckpointFsyncDuration| long  |  Duration of the sync phase of the last checkpoint in milliseconds.
+|LastCheckpointListenersExecuteDuration|  long|    Duration of the checkpoint execution listeners under write lock in milliseconds.
+|LastCheckpointLockHoldDuration|  long|    Duration of the checkpoint lock hold in milliseconds.
 |LastCheckpointLockWaitDuration|  long|    Duration of the checkpoint lock wait in milliseconds.
-|LastCheckpointMarkDuration | long  |  Duration of the checkpoint lock wait in milliseconds.
+|LastCheckpointMarkDuration | long  |  Duration of the checkpoint mark in milliseconds.
 |LastCheckpointPagesWriteDuration|    long|    Duration of the checkpoint pages write in milliseconds.
 |LastCheckpointTotalPagesNumber|  long|    Total number of pages written during the last checkpoint.
+|LastCheckpointSplitAndSortPagesDuration|  long|    Duration of splitting and sorting checkpoint pages of the last checkpoint in milliseconds.
+|LastCheckpointStart|  long|    Start timestamp of the last checkpoint.
+|LastCheckpointWalRecordFsyncDuration|  long|    Duration of the WAL fsync after logging CheckpointRecord on begin of the last checkpoint in milliseconds.

Review comment:
       ```suggestion
   |LastCheckpointWalRecordFsyncDuration|  long|    Duration of the WAL fsync after logging CheckpointRecord on the start of the last checkpoint in milliseconds.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org