You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "Harshil-1603 (via GitHub)" <gi...@apache.org> on 2026/10/14 14:11:04 UTC
[PR] docs: explain timestamp timezone comparisons [datafusion]
Harshil-1603 opened a new pull request, #26294:
URL: https://github.com/apache/datafusion/pull/26294
## Which issue does this PR close?
Closes #10344.
## Rationale for this change
The type reference describes timestamp types but does not explain how timestamps with different or missing timezone metadata compare. In particular, a naive timestamp is interpreted in the other operand's timezone, which can surprise users expecting UTC.
## What changes are included in this PR?
Document Arrow's aware and naive timestamp representation, the comparison coercion rules, two runnable SQL examples, and the distinction from timestamp arithmetic. This is documentation only and does not change timestamp behavior.
## What is the testing strategy for this PR?
- Extracted both new SQL examples from the Markdown and executed them against this checkout; both returned the documented `true` result.
- Confirmed the arithmetic limitation with a query that subtracts timestamps with different timezone metadata.
- `cargo fmt --all -- --check`, the documentation Prettier script, and `git diff --check` passed.
- Full Clippy remains blocked by the three existing `mutable_key_type` errors in `datafusion/optimizer/src/push_down_filter.rs` (#26181). No runtime code is changed.
## Are there any user-facing changes?
The SQL type reference now explains timezone semantics and comparisons. This contribution was prepared with AI assistance and checked against the current coercion implementation and actual query results.
@alamb, could you please enable CI for this documentation contribution?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] docs: explain timestamp timezone comparisons [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed pull request #26294: docs: explain timestamp timezone comparisons
URL: https://github.com/apache/datafusion/pull/26294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] docs: explain timestamp timezone comparisons [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #26294:
URL: https://github.com/apache/datafusion/pull/26294#issuecomment-6506371888
Thanks for the contribution! I am closing this under DataFusion's AI Dump policy.
https://datafusion.apache.org/contributor-guide/ai-policy.html#what-is-an-ai-dump-and-why-it-is-not-helpful
This has the hallmarks of AI code that was not reviewed by the author: a docs-only change whose testing section discusses clippy, opened the same day as a sibling PR that admits its checks did not pass.
If you would like to continue, please open a focused PR in your own words that you have reviewed and understand, and we are happy to help with review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org