You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/02 08:10:07 UTC
[GitHub] [dubbo] guohao opened a new issue #8661: [3.0-Triple] It is no need to estimate header size before send
guohao opened a new issue #8661:
URL: https://github.com/apache/dubbo/issues/8661
- [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [x] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
According to [rfc7540](https://datatracker.ietf.org/doc/html/rfc7540#section-6.5.2), `SETTINGS_MAX_HEADER_LIST_SIZE` is negotiated in `SETTING` frame. The setting constrains the <b>total</b> header size allowed in HeaderFrame. But it is hard to estimate before `HPACK` compression. Therefore is needless and unreliable to judge if the header is too large to send.
What need to do:
1. Remove `org.apache.dubbo.rpc.protocol.tri.TripleUtil#overEachHeaderListSize` method.
2. Get netty write result `promise` and pass error to upper layer.
3. Write UT to verify above modifications.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] candyaaa removed a comment on issue #8661: [3.0-Triple] It is no need to estimate header size before send
Posted by GitBox <gi...@apache.org>.
candyaaa removed a comment on issue #8661:
URL: https://github.com/apache/dubbo/issues/8661#issuecomment-918117023
Formatting your IDEA using dubbo_codestyle_for_idea.xml is a crucial step before contributing code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] CrazyHZM commented on issue #8661: [3.0-Triple] It is no need to estimate header size before send
Posted by GitBox <gi...@apache.org>.
CrazyHZM commented on issue #8661:
URL: https://github.com/apache/dubbo/issues/8661#issuecomment-924609674
Solved in #8774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] CrazyHZM closed issue #8661: [3.0-Triple] It is no need to estimate header size before send
Posted by GitBox <gi...@apache.org>.
CrazyHZM closed issue #8661:
URL: https://github.com/apache/dubbo/issues/8661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] shanuo0312 commented on issue #8661: [3.0-Triple] It is no need to estimate header size before send
Posted by GitBox <gi...@apache.org>.
shanuo0312 commented on issue #8661:
URL: https://github.com/apache/dubbo/issues/8661#issuecomment-911360458
@i will solve it@
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] candyaaa commented on issue #8661: [3.0-Triple] It is no need to estimate header size before send
Posted by GitBox <gi...@apache.org>.
candyaaa commented on issue #8661:
URL: https://github.com/apache/dubbo/issues/8661#issuecomment-918117023
Formatting your IDEA using dubbo_codestyle_for_idea.xml is a crucial step before contributing code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org