[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #862: Add support for composite key

[GitBox <gi...@apache.org>]

vinothchandar commented on a change in pull request #862: Add support for composite key
URL: https://github.com/apache/incubator-hudi/pull/862#discussion_r326903080
 
 

 ##########
 File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/keygen/TimestampBasedKeyGenerator.java
 ##########
 @@ -102,7 +109,12 @@ public HoodieKey getKey(GenericRecord record) {
             "Unexpected type for partition field: " + partitionVal.getClass().getName());
       }
 
-      return new HoodieKey(DataSourceUtils.getNestedFieldValAsString(record, recordKeyField),
+      return new HoodieKey(
+          fields.stream()
+              .map(
+                  recordKeyField ->
+                      DataSourceUtils.getNestedFieldValAsString(record, recordKeyField))
+              .collect(Collectors.joining(".")),
 
 Review comment:
   @bvaradar any thoughts? lets make a call on this PR? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services