You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by pritisarap12 <gi...@git.apache.org> on 2015/12/08 12:03:35 UTC

[GitHub] cloudstack pull request: CLOUDSTACK-9121: Adding VmSnapshot valida...

GitHub user pritisarap12 opened a pull request:

    https://github.com/apache/cloudstack/pull/1190

    CLOUDSTACK-9121: Adding VmSnapshot validation in testpath_revert_snap.py

    In testpath_revert_snap.py, there was no code to check if VM snapshot is created or not hence adding code for snapshot validation.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pritisarap12/cloudstack CLOUDSTACK-9121-Adding-VmSnapshot-validation-in-testpath_revert_snap.py

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1190.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1190
    
----
commit 1cf44dee3a94dcac765aff9b2827e20cd05f971f
Author: Priti Sarap <pr...@clogeny.com>
Date:   2015-12-08T10:59:13Z

    CLOUDSTACK-9121: Adding VmSnapshot validation in testpath_revert_snap.py

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9121: Adding VmSnapshot valida...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/1190


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9121: Adding VmSnapshot valida...

Posted by pritisarap12 <gi...@git.apache.org>.
Github user pritisarap12 commented on the pull request:

    https://github.com/apache/cloudstack/pull/1190#issuecomment-162851170
  
    Testpath Result:
    
    Test revert snapshot on XenServer ... === TestName: test_01_check_revert_snapshot | Status : SUCCESS ===
    ok
    
    ----------------------------------------------------------------------
    Ran 1 test in 119.808s
    
    OK



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] cloudstack pull request: CLOUDSTACK-9121: Adding VmSnapshot valida...

Posted by Sanjeev N <sa...@apache.org>.
LGTM!!

Test revert snapshot on XenServer ... === TestName:
test_01_check_revert_snapshot | Status : SUCCESS ===

ok



----------------------------------------------------------------------

Ran 1 test in 132.503s



OK

On Wed, Dec 23, 2015 at 5:44 PM, pvr9711 <gi...@git.apache.org> wrote:

> Github user pvr9711 commented on the pull request:
>
>     https://github.com/apache/cloudstack/pull/1190#issuecomment-166878697
>
>     @remibergsma can you please check this commit and merge it in?
> Thanks, Raja
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] cloudstack pull request: CLOUDSTACK-9121: Adding VmSnapshot valida...

Posted by pvr9711 <gi...@git.apache.org>.
Github user pvr9711 commented on the pull request:

    https://github.com/apache/cloudstack/pull/1190#issuecomment-166878697
  
    @remibergsma can you please check this commit and merge it in?  Thanks, Raja


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9121: Adding VmSnapshot valida...

Posted by nitt10prashant <gi...@git.apache.org>.
Github user nitt10prashant commented on the pull request:

    https://github.com/apache/cloudstack/pull/1190#issuecomment-172466590
  
    LGTM 
    Test revert snapshot on XenServer ... === TestName:test_01_check_revert_snapshot | Status SUCCESS ===
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---