You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "uros-b (via GitHub)" <gi...@apache.org> on 2026/07/28 07:59:04 UTC
[PR] API: Add missing @return Javadoc to ManageSnapshots methods [iceberg]
uros-b opened a new pull request, #17394:
URL: https://github.com/apache/iceberg/pull/17394
"`rollbackTo` and `renameBranch` were the only fluent methods in `ManageSnapshots` missing the "@return this for method chaining" tag that every other method in the interface documents. This adds it for consistency. Javadoc-only; non-breaking (no signature change, revapi-clean).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API, Core: Add missing @return Javadoc [iceberg]
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on PR #17394:
URL: https://github.com/apache/iceberg/pull/17394#issuecomment-5145823976
Merged, thanks @uros-b and @nastra , lets do the follow ups
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API: Add missing @return Javadoc to fluent/namespace method [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on PR #17394:
URL: https://github.com/apache/iceberg/pull/17394#issuecomment-5127785325
I did a quick analysis and we have the same pattern in, so we might want to update those places as well to be consistent
- `util/BinaryUtil#truncateBinary(ByteBuffer, int)`
- `util/BinaryUtil#truncateBinaryUnsafe(ByteBuffer, int)`
- `io/FileIO#properties()`
- `formats/ReadBuilder#split(long, long)`, `#caseSensitive(boolean)`, `#filter(Expression)` — siblings `set`/`setAll` already say "@return this for method chaining"
- `TrackingBuilder#added`, `#from`, `#deleted`, `#replaced`
- `TrackedFile#copyWithStats(Set)`
- `MetricsConfig#forTable(Table)`
- `ManifestFilterManager#buildSummary(Iterable)`
- `MergingSnapshotProducer#addedDeleteFiles(...)`
- `data/avro/RawDecoder#create(...)`
- `encryption/NativeFileCryptoParameters#create(ByteBuffer)`
- `io/PartitionedWriter#partition(T)` and `io/PartitionedFanoutWriter#partition(T)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API: Add missing @return Javadoc to ManageSnapshots methods [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #17394:
URL: https://github.com/apache/iceberg/pull/17394#discussion_r3666841167
##########
api/src/main/java/org/apache/iceberg/ManageSnapshots.java:
##########
@@ -66,6 +66,7 @@ public interface ManageSnapshots extends PendingUpdate<Snapshot> {
*
* @param snapshotId long id of snapshot id to roll back table to. Must be an ancestor of the
* current snapshot
+ * @return this for method chaining
Review Comment:
do we have other places in the codebase that are missing the return?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API: Add missing @return Javadoc to fluent/namespace method [iceberg]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on code in PR #17394:
URL: https://github.com/apache/iceberg/pull/17394#discussion_r3678443555
##########
api/src/main/java/org/apache/iceberg/ManageSnapshots.java:
##########
@@ -66,6 +66,7 @@ public interface ManageSnapshots extends PendingUpdate<Snapshot> {
*
* @param snapshotId long id of snapshot id to roll back table to. Must be an ancestor of the
* current snapshot
+ * @return this for method chaining
Review Comment:
Made a few more updates, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API, Core: Add missing @return Javadoc [iceberg]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #17394:
URL: https://github.com/apache/iceberg/pull/17394#issuecomment-5144068093
Thank you @nastra and @szehon-ho!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API, Core: Add missing @return Javadoc [iceberg]
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho merged PR #17394:
URL: https://github.com/apache/iceberg/pull/17394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org