[jira] [Commented] (HADOOP-10035) Cleanup TestFilterFileSystem

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-10035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572748#comment-14572748 ] 

Hadoop QA commented on HADOOP-10035:
------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |   6m 47s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to include 1 new or modified test files. |
| {color:green}+1{color} | javac |   7m 29s | There were no new javac warning messages. |
| {color:green}+1{color} | release audit |   0m 19s | The applied patch does not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   1m  4s | There were no new checkstyle issues. |
| {color:red}-1{color} | whitespace |   0m  0s | The patch has 1  line(s) that end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install |   1m 31s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 50s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | common tests |  23m 31s | Tests passed in hadoop-common. |
| | |  43m  7s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12737548/HADOOP-10035.3.patch |
| Optional Tests | javac unit findbugs checkstyle |
| git revision | trunk / d7e7f6a |
| whitespace | https://builds.apache.org/job/PreCommit-HADOOP-Build/6918/artifact/patchprocess/whitespace.txt |
| hadoop-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/6918/artifact/patchprocess/testrun_hadoop-common.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/6918/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6918/console |


This message was automatically generated.

> Cleanup TestFilterFileSystem
> ----------------------------
>
>                 Key: HADOOP-10035
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10035
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.1.1-beta
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>              Labels: BB2015-05-TBR
>         Attachments: HADOOP-10035.1.patch, HADOOP-10035.2.patch, HADOOP-10035.3.patch, HADOOP-10035.patch
>
>
> Currently TestFilterFileSystem only checks for FileSystem methods that must be implemented in FilterFileSystem with a list of methods that are exception to this rule. This jira wants to make this check stricter by adding a test for ensuring the methods in exception rule list must not be implemented by the FilterFileSystem.
> This also cleans up the current class that has methods from exception rule list to interface to avoid having to provide dummy implementation of the methods.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)