[jira] Updated: (NET-251) Move class "ThreadContainer" from Threader.java into its own source file

["Martin Oberhuber (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/NET-251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Oberhuber updated NET-251:
---------------------------------

              Priority: Trivial  (was: Critical)
           Description: 
In the commons-net-2.0.zip binary release, find commons-net-2.0.jar

This JAR contains "org.apache.commons.net.nntp.ThreadContainer.class" which has no counterpart in any of the released source archives (I checked commons-net-2.0-sources.jar which is included in the binary dist as well as the original source dist). Looking in SVN, the source is also not there: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/java/org/apache/commons/net/nntp/

I find this issue problematic, because if I am unable to check the provenience of that binary file, I might be introducing license problems. Just assume that the problematic "ThreadContainer.class" contains GPL'd code, I might end up running into severe issues.


  was:
In the commons-net-2.0.zip binary release, find commons-net-2.0.jar

This JAR contains "org.apache.commons.net.nntp.ThreadContainer.class" which has no counterpart in any of the released source archives (I checked commons-net-2.0-sources.jar which is included in the binary dist as well as the original source dist). Looking in SVN, the source is also not there: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/java/org/apache/commons/net/nntp/

I find this issue problematic, because if I am unable to check the provenience of that binary file, I might be introducing license problems. Just assume that the problematic "ThreadContainer.class" contains GPL'd code, I might end up running into severe issues.

For me, this issue blocks adoption of Commons Net 2.0. 
Please check ASAP whether that rogue file can be removed without causing problems, then get rid of it.

            Issue Type: Improvement  (was: Bug)
    Remaining Estimate: 0.5h  (was: 1h)
     Original Estimate: 0.5h  (was: 1h)
               Summary: Move class "ThreadContainer" from Threader.java into its own source file  (was: Commons Net 2.0 binary release contains rogue "ThreadContainer.class" file)

Building from source myself and grepping the sources, I found that the odd "ThreadContainer.java" is actually contained in class "Threader.java".

This is bad practice and may not even work properly on some Java compilers.

Please move ThreadContainer.java into its own file (compilation unit). I can absolutely see no sense in having this included inside Threader.java.

> Move class "ThreadContainer" from Threader.java into its own source file
> ------------------------------------------------------------------------
>
>                 Key: NET-251
>                 URL: https://issues.apache.org/jira/browse/NET-251
>             Project: Commons Net
>          Issue Type: Improvement
>    Affects Versions: 2.0
>         Environment: Download from http://commons.apache.org/downloads/download_net.cgi file http://mirror.deri.at/apache/commons/net/binaries/commons-net-2.0.zip
>            Reporter: Martin Oberhuber
>            Priority: Trivial
>             Fix For: 2.0
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> In the commons-net-2.0.zip binary release, find commons-net-2.0.jar
> This JAR contains "org.apache.commons.net.nntp.ThreadContainer.class" which has no counterpart in any of the released source archives (I checked commons-net-2.0-sources.jar which is included in the binary dist as well as the original source dist). Looking in SVN, the source is also not there: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/java/org/apache/commons/net/nntp/
> I find this issue problematic, because if I am unable to check the provenience of that binary file, I might be introducing license problems. Just assume that the problematic "ThreadContainer.class" contains GPL'd code, I might end up running into severe issues.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.